search

ich777 / docker-steamcmd-server

Simple Dockerfile that installs steamcmd and a selected game server
115 stars 95 forks source link

steamcmd:arkse server pass issue #29

Closed xstar97 closed 1 year ago

xstar97 commented 1 year ago

in the start server script it appears that the a password param is hardcoded and its required. -> https://github.com/ich777/docker-steamcmd-server/blob/e692243d582d555f5afab3b96634b3732f9b99a4/scripts/start-server.sh#L72

can SRV_PWD be empty or have a validation check if it is or not and append the param in the script otherwise dont?

while passwords are great sometimes not setting a password is ideal for some instances.

i run this on scale, using truecharts repo -> https://github.com/truecharts/charts/tree/master/charts/incubator/arksurvivalevolved

ich777 commented 1 year ago

Is it not possible to set the variable SVR_PWD empty on Scale?

Even if it‘s hard coded you can leave it empty and no password will be set when someone is trying to connect. The README.md also says that. I have a few users on Unraid which are using it that way.

However if it‘s not possible to leave the variable empty like on Portainer I can leave the SRV_PWD empty in the Dockerfile.

xstar97 commented 1 year ago

ok thanks for the clarification, we wanted to be sure that it can be set as empty since the param was hardcoded

ich777 commented 1 year ago

ok thanks for the clarification, we wanted to be sure that it can be set since the param was hardcoded

I‘ve tested it back then when I created the container that it workis with a empty variable too, otherwise I wouldn‘t have put it in the README.md. Please let me know when something changed, but since I don‘t heard back from anyone who is running the container without a password I assumed that it‘s working.

I don‘t play much these days anymore because I have a lot of containers to maintain nowadays. 😅

Anyways, I wish you Merry Christmas and Happy Holidays.

xstar97 commented 1 year ago

ok thanks for the clarification, we wanted to be sure that it can be set since the param was hardcoded

I‘ve tested it back then when I created the container that it workis with a empty variable too, otherwise I wouldn‘t have put it in the README.md. Please let me know when something changed, but since I don‘t heard back from anyone who is running the container without a password I assumed that it‘s working.

I don‘t play much these days anymore because I have a lot of containers to maintain nowadays. 😅

Anyways, I wish you Merry Christmas and Happy Holidays.

ty you too :)