Update query string decoding to decode pluses

icicleio / http

HTTP component for Icicle

MIT License

61 stars 5 forks source link

Update query string decoding to decode pluses #22

Open jvasseur opened 8 years ago

jvasseur commented 8 years ago

When decoding a query string pluses are not decoded.

This is a problem for 2 reasons:

It doesn't match the PHP behavior.
When using this value to create a new request the plus is encoded resulting in a different request.

Since the decode function is used to decode other parts of the URI I didn't update it and instead used urldecode directly when decoding query parts.

coveralls commented 8 years ago

Coverage remained the same at 61.346% when pulling 065ad87a59a3cf3b02991a34b38c3e3f8e2629e8 on jvasseur:fix-pluses-decoding into 69e66acc34e930953b6fda6c366173932051234f on icicleio:v0.3.x.

sagebind commented 8 years ago