icloud-photos-downloader / icloud_photos_downloader

A command-line tool to download photos from iCloud
MIT License
7.02k stars 563 forks source link

Every version Shuts itself down #963

Closed ChillyFlake closed 1 month ago

ChillyFlake commented 1 month ago

Overview

Essentially no matter what version i use, icloudpd-ex-1.23.4-windows-amd64, icloud-1.23.4-windows-amd64, or icloud-1.23.4-windows-amd64, even a 1.15 something that i know for a FACT worked earlier in the year, they all open, and either shut themselves off as soon as they load text, or they let me enter my username, tell me i did it wrong, then shut off.

Steps to Reproduce

  1. Open it
  2. Wait
  3. If it doenst do it by itself, enter any command- accepted or otherwise-, and wait

Expected Behavior

I expect it to function

Actual Behavior

It doesnt

Context

I dunno i cant think of anything that would have changed between now and when 1.15 was the latest + why 1.15 wouldnt work + + why any and all versions (windows 64 amd is my comp) just bungle instantly. i also cant get any docker to work and i dont know the first thing about building myself, and i would LOVE if i had to restart my pc as little as possible (already have once) because it takes about an hour to go from on to off to back to on (which i know because i reset it twice today.)

AndreyNikiforov commented 1 month ago

How are you running executable? What does it tell you when you run it? Run it in opened command window, so you can see the output.

icloudpd is the one that download photos, icloud is for managing saved credentials. Choose the one you need. Worth checking documentation

ChillyFlake commented 1 month ago

How are you running executable? What does it tell you when you run it? Run it in opened command window, so you can see the output.

I was downloading it and then running it. I tried that numerous times, but every time itd ask for my username, and i'd give it, it'd close after telling me i didnt do correct syntax (not including --directory for example). Key thing to note is if i DID include the necessary parts, passwords and instructions, itd open a bigger menu that is clearly the next step, and then crash.

icloudpd is the one that download photos, icloud is for managing saved credentials. Choose the one you need. Worth checking documentation

Funnily enough, the documentation has NO actual instructions as far as i can see for just running it normally. As in, it tells you what each command does, sort of, but theres not really a dummys guide to "Start with this copy paste and tailor it to your needs". (I assume cause the program itself would tell you all that.) All the installation instructions are obviously for dockers or building yourself since you just download it and run it if you go that route, and nowhere is there a reason my experience would be happening. With that said, i started with icloudpd, and when that didnt work no matter what i did, i tried the others in a vain hope that something would happen. Some of them crashed before putting out anything, and some of them didnt even let me type at all.

EDIT FORGOT: I also ran it in a command prompt, admin and not, and it wouldnt crash there, but whenever it'd reach a point when it would crash had i launched the exe by itself, it just softlocks. As in, it doesnt close, but i cant type anything, or interact in any way with it, effectively doing the same thing.

AndreyNikiforov commented 1 month ago

To help you I need three answers:

ChillyFlake commented 1 month ago

I'm attatching a video including all versions ive tried (some 23.4 some 15.1) to show exactly what is happening, with all sensitive info removed

https://github.com/user-attachments/assets/be2fbdfb-b4e3-404f-a8b6-4696693894ac

AndreyNikiforov commented 1 month ago

Do you have command that you used last time that icloudpd worked for you? You keep mentioning that 1.15 worked and exactly the same params should continue to work in 1.23

Great that you figured how to use --help param - it should give you all other params. We do have Reference online too.

Using icloudpd --username your@email.address --directory photos as you mentioned, should be the minimum that works. What error does it give to you?

ChillyFlake commented 1 month ago

pasting that command directly in both 1.15.1 and 1.23.4 (the icloudpd versions) does the same thing as in the video and previous reply. replacing the username with my own made no difference, and even with the proper directory photos direction it still says --auth-only, --directory, --list-libraries or --list-albums are required

image

(the above happens if i remove the icloudpd part as well given this example is in the pd, and i cant get any other version of 1.23.4 to let me type at all) and then after saying that, it instantly closes itself. the only way i got this screenshot was by quickdraw style pressing print screen, which i failed to do a few times because of how quickly it closed.

So, like, no error is given? and i didnt think to write down the command i used last time, i figured when i next used it i could figure it out in 10 minutes or less like i had done the first time with the in program instructions

AndreyNikiforov commented 1 month ago

pasting that command directly in both 1.15.1 and 1.23.4 (the icloudpd versions) does the same thing as in the video and previous reply. replacing the username with my own made no difference, and even with the proper directory photos direction it still says --auth-only, --directory, --list-libraries or --list-albums are required

image

(the above happens if i remove the icloudpd part as well given this example is in the pd, and i cant get any other version of 1.23.4 to let me type at all) and then after saying that, it instantly closes itself. the only way i got this screenshot was by quickdraw style pressing print screen, which i failed to do a few times because of how quickly it closed.

So, like, no error is given? and i didnt think to write down the command i used last time, i figured when i next used it i could figure it out in 10 minutes or less like i had done the first time with the in program instructions

Screenshot does not have the command you pasted. It is usually easier to understand what you are doing when you have command prompt, command you entering, and output. Copy-paste is enough (and you can replace sensitive info) - no need for screenshots or videos (btw video you uploaded on github plays for couple seconds only, so it is useless).

Given that we are discussing how to run cli on windows, I suggest:

  1. get yourself comfortable with cli on windows. See if you can list content of a couple of folders with "dir" command and have results saved in text files with the help of notepad
  2. proceed with icloudpd experiments
ChillyFlake commented 1 month ago

the screenshot does have the command pasted? literally directly from your last responce, icloudpd --username your@email.address --directory photos, which ive run both exactly as pasted, replacing the dummy email with my own, including --password [my password in every variable slot, replacing the last command with the other ones the program briefly suggest, and nothing else works any differently. I also can't copy the terminal or anything it does, because as ive hopefully made clear i have maybe half a second before it closes.

I am also familiar with the command line enough, and have used it both admin or otherwise to test these exe's multiple times. Including navigating directories and syntax and all that. As i said in one of my first replies, running it in the command prompt from the directory does the same thing, but instead of closing the window, it just returns me to the directory and shuts itself as a program down.

and just for posterity, heres the video uploaded to youtube of what happens whenever i try and use any of them.

With that all said, i feel i cant really do any more experimenting without a better understanding of the program or whatever is causing this bug, whether it be my system or not, because simply nothing i do will produce anything except a no error code no feedback shutdown of the program

AndreyNikiforov commented 1 month ago

Your video shows that you are starting icloudpd from UI, not from command prompt. Start command prompt, then familiarize yourself with commands there, e.g. "dir", copy-pasting command and output, etc, and then experiment with icloudpd.

ChillyFlake commented 1 month ago

As i have said a few times now, i am already familier with command prompt, use it regularly, and have tested these programs with it, navigating to my desktop and running them in the command line. And as i've previously said, the effect is identical to running them from ui, the only difference being it terminates itself but i stay in the command prompt, where as it closes when i double click it as an icon.

To repeat, i have already done that numerous times, and it will simply behave identically to if i had clicked the icon, except crashing just ends the process but returns me to the directory in command prompt instead of closing the window.

But because you dont seem to beleive me, i've went ahead and screenshotted it for you image

AndreyNikiforov commented 1 month ago

But because you dont seem to beleive me, i've went ahead and screenshotted it for you image

Nice. You can just copy-paste text from the command prompt - may be easier to work with.

You are running icloudpd without any parameters (based on screenshot). Now try to run icloudpd --username your@email.address --directory your_path_somewhere and post here. Should show a) what you are executing b) the output of the execution

ChillyFlake commented 1 month ago

I mean this with no animosity, but are you not fully reading my responses? Because it feels like you are, at most, skimming them, and not listening to what i've been saying.

But, just to give you the info you are asking for, here is another screenshot, as i find it more secure and telling than just copy pasting the text. image

As you can see, whether i include the username, whether i include icloudpd at the start, whether i include a password, nothing works. It's not that it doesnt work, its that it isnt recognizing *anything* i've put in. It doesn't see these as incomplete commands, it plain does not see them as commands.

AndreyNikiforov commented 1 month ago

But, just to give you the info you are asking for, here is another screenshot, as i find it more secure and telling than just copy pasting the text. image

As you can see, whether i include the username, whether i include icloudpd at the start, whether i include a password, nothing works. It's not that it doesnt work, its that it isnt recognizing anything i've put in. It doesn't see these as incomplete commands, it plain does not see them as commands.

From what I can tell, you are NOT running icloudpd with parameters according to this screenshot. It should look like:

c:\Users\Youpath>icloudpd-1.23.4-windows-amd64 --username what@ever.email --directory your_path_somewhere
...output shown here...

That can happen when you press "Enter" right after icloudpd-1.23.4-windows-amd64 without specifying parameters in the same line. That can also happen, for example, when your command and parameters are saved in text file as separate lines and you copy-paste them into command prompt.

ChillyFlake commented 1 month ago

without including the password, it would simply ask for a password, but not let me input anything. That is, the command prompt still lets me click and highlight stuff, but it no longer recognized any inputs.

image

With that said, if i include the password in the initial prompt, like youve shown above (which took some troubleshooting because i didnt notice some syntax, chalk that up to no ones fault since i was copy pasting) it actually works! I had to terminate it cause i wanted delete after download but it was easy enough, and its running right now.

With that said, i still maintain that something about the program is bugging out on me. I definitly did not have to go through this rigamarole of running it from command line the last time i had done it, and the help menus in program that i can see for a fraction of a second dont make any sense if the program is SUPPOSED to auto shut down. That, combined with the freezing when it didnt get the entire prompt at once, but it DOES prompt me to give the rest of it, and freezes before i can do so, still tell me theres an issue. While i didn't think to run the command in the same line as running the program (so hats of to you for letting me know i could), that shouldnt be the ONLY way to get this to work when theres clearly instructions for not having to do that?

Not a complaint though, clearly its my machine or download in some way. doesnt matter much either since now its working so yay