search

iconify / api

Iconify API script. Search engine for icons, provides icon data on demand for icon components, dynamically generates SVG.
MIT License
96 stars 34 forks source link

fix: switched to yarn since npm fails to install pnpm on arm64v8 #9

Closed markus-li closed 1 year ago

markus-li commented 1 year ago

Once I ran multi-platform builds I noticed that there was a failure for arm64v8.

cyberalien commented 1 year ago

Not a fan of yarn. This repo doesn't really use any extra functionality from pnpm, so maybe just switch to npm?

markus-li commented 1 year ago

since you have a pnpm lock file I wanted to keep using that, yarn in this case is only used to install pnpm, not for anything else. EDIT: And if we would be using npm, that'd would have to be updated anyway, so can just as well install pnpm. I can see if I can uninstall yarn (from APT) after installing pnpm.

cyberalien commented 1 year ago

Switched repository to npm. It doesn't make any difference for this repo.

markus-li commented 1 year ago

Ok, I'll switch to npm for docker as well then. Just need to make sure updating of npm works in all platforms. I've run tests with having yarn removed after installing pnpm and that worked as well. I'll keep that one in mind for the future.

cyberalien commented 1 year ago

Merged. Thanks!