icra / ecam

Energy performance and Carbon emissions Assessment and Monitoring tool (Lluís Bosch, Lluís Corominas, IWA, Wacclim project, GIZ)
http://wacclim.org/ecam
Other
13 stars 17 forks source link

Leap years not considered #485

Closed Anveizaga closed 3 years ago

Anveizaga commented 3 years ago

The assessment period can be selected through default calenders. Unfortunately leap years, which should have 366 days, have 365 days according to the ECAM. This could affect the results when calculating per year.

holalluis commented 3 years ago

Dear @Anveizaga,

In theory, ecam treats leap years correctly. image

Can you send an example where this is not calculated correctly? Thanks!

Anveizaga commented 3 years ago

Hola @holalluis, thank you for answer, I think I have a confusion there because 1 year, for some people (including me) would be considered from 01/01/2021 to 31/12/2021, but for other people exactly like you showed in the image. We will have to explain this better in the manual. So I will close this comment and thank you for your fast reply! Best, Adriana

holalluis commented 3 years ago

I think the easiest way to explain it is to consider that the last day is not included in the assessment period