flensrocker commented 2 years ago

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

Fixes #788

codecov[bot] commented 2 years ago

Codecov Report

Merging #791 (5c314d9) into master (75d1cf8) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #791   +/-   ##
=======================================
  Coverage   74.71%   74.71%           
=======================================
  Files          72       72           
  Lines        8468     8468           
=======================================
  Hits         6327     6327           
  Misses       2141     2141

Impacted Files	Coverage Δ
src/ICSharpCode.SharpZipLib/Tar/TarInputStream.cs	`63.20% <100.00%> (ø)`
src/ICSharpCode.SharpZipLib/Tar/TarOutputStream.cs	`67.83% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

piksel commented 2 years ago

Ehm, yeah, that was much more obvious than I thought. Probably should have started looking there... 😁

flensrocker commented 2 years ago

I looked at those lines more than once... and didn't see it.

I started to use enums instead of booleans for such switches because they are more readable.

icsharpcode / SharpZipLib

fix(tar): use sync codepath on sync methods #791

Codecov Report