search

icub-tech-iit / ergocub-gazebo-simulations

Repository containing the models and the simulations for ergoCub
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

Fix torso modification errors #5

Closed GrmanRodriguez closed 3 years ago

GrmanRodriguez commented 3 years ago

This PR adresses #3

The torso modifiers were wrong, which we did not notice because the origin was not modified for box geometries.

I added the modification of the origin for box geometries modifiers.

I also added the calculate_dimensions_from_origin flag to False in the torso modifiers since the torso does not need modification.

Finally, I rewrote the declaration of the torso modifiers for added clarity with respect to which flags are set and which are not.

GrmanRodriguez commented 3 years ago

Thanks to @CarlottaSartore for finding the issue! Keep us update with anything else you may find.