icza / scelight

The source code of the Scelight project with all its modules.
https://sites.google.com/site/scelight/
Apache License 2.0
123 stars 19 forks source link

Add example filters #3

Open NullVoxPopuli opened 8 years ago

NullVoxPopuli commented 8 years ago

Like, a common one:

1v1 ranked ladder

Maybe also games where I've lost.

icza commented 8 years ago

To my knowledge, the info whether a replay is ranked or unranked is not stored in the replay. It might be possible to somehow deduce this info from data stored in the replay, but I haven't figured it out how.

The rest (filter for 1v1 ranked or unranked matches) is already possible: Replay filters, add 2 filters:

[Replay] Format = 1v1 AND [Replay] Game mode = AutoMM

It's also possible to include whether you (a specific player) lost or won, e.g.

[Player A] Toon = 'xxx' AND [Player A] Result = Defeat
icza commented 8 years ago

Reading again the issue title maybe that's not what I thought you want.

Do you mean built-in examples? That people can choose without having to construct the filters themselves?

NullVoxPopuli commented 8 years ago

yeah! build in, pre-made filters :-)

icza commented 8 years ago

But just as a side note... you know you can save filters once you've constructed them, right? And of course you can load saved filters...

NullVoxPopuli commented 8 years ago

yeah, I have a couple saved filters. But it took me a while to get them configured the way I want. the or/and logic dropdowns behave kinda funky / not what I'm used to

icza commented 8 years ago

Yeah, I know, because filters and grouping (parenthesis) are provided in a "linear" fashion (sequentially), but evaluating a series of AND / OR filters with grouping requires "hierarchical" representation. That's why there's a "Filters Structure Preview" which helps understanding what it means that you assembled.