Closed caleb-sitton-inl closed 1 month ago
Job CentOS 8 on ce3d555 : invalidated by @GabrielSoto-INL
Job CentOS 8 on ce3d555 : invalidated by @GabrielSoto-INL
problem with cloning, trying again?
Just a general comment for clarification: seems there are two ways of accessing the coverage, correct?
Also, an additional note that after this PR is merged, @caleb-sitton-inl it may be good to summarize this in a Discussion for developers in this repo
Just a general comment for clarification: seems there are two ways of accessing the coverage, correct?
- download the "Artifacts" left over from the coverage run in the "Checks" tab or
- navigate here and scroll to the bottom of the page:
Also, an additional note that after this PR is merged, @caleb-sitton-inl it may be good to summarize this in a Discussion for developers in this repo
Yes, you can view the list of artifacts (which currently just contains the coverage results) in either of these ways. As for the Discussion, sounds good; I'll go ahead and create that once it's merged.
This looks like it's coming along great. Have we documented how to view the coverage reports, and placed that documentation somewhere new developers can get familiar with it?
This looks like it's coming along great. Have we documented how to view the coverage reports, and placed that documentation somewhere new developers can get familiar with it?
@PaulTalbot-INL Not yet; the current plan is to create a github Discussion with that information once the PR has been merged. Also, when the github action is run, it will create an annotation that should be relatively obvious and will contain both the overall number for coverage as well as a very brief description of how to access the full report.
Pull Request Description
What issue does this change request address?
376
What are the significant changes in functionality due to this change request?
This request replaces the call to
run_tests
in the part of the github action running on linux with a call tocheck_py_coverage.sh
. This does not impact the functionality of the tests being run in any way. It provides a brief message with an easily visible percentage for code coverage when the action is complete. This message also directs users to a thorough html report on coverage available under the 'Artifacts' section.The disadvantage of this addition is the overhead run time whenever the github action is activated. Running locally, checking coverage adds about 19% overhead relative to plain
run_tests
. Since coverage is only being run for one of the two calls torun_tests
in this github action, the impact of the overhead is halved to 9-10% (considering only time spent executing tests, not time for setup and other activities the github action executes). While it does save time, only checking coverage for a single OS would not capture deviations in coverage caused by different scripts being run per the OS. An example of this is the selection of a pyomo solver, which can depend on the OS platform running the script.For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.