Closed lin-yang-ly closed 1 month ago
Job Documentation, step Sync to remote on af1aea1 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage, step Generate coverage on af1aea1 wanted to post the following:
Coverage did not change
This comment will be updated on new commits.
@simopier Thank you! All changes are updated in all six cases.
Awesome contribution! Thank you @lin-yang-ly!
I still need to thoroughly check the math for ver-1ic and ver-1ie, but things are looking really good. I have many comments (mostly minor), and teh following requests and questions:
- Please find ways (by increasing the time step or using an adaptive time step) to make these tests run faster. Tests should run in less than ~2 seconds and they are taking much longer on the CI environment:
tests/ver-1ia/tests [16.868s] tests/ver-1ie/tests [12.125s] tests/ver-1if/tests [11.396s] tests/ver-1ib/tests [7.771s] tests/ver-1ic/tests [7.135s] tests/ver-1id/tests [6.011s]
- The results for ver-1ie seem a bit different than what predicted by TMAP7, why is that?
- Why did you not use the analytical solution with the modified
tau
value in ver-1ie? Is that because you found an analytical solution that already works when the two pressures are equal?
@simopier I just update them with the comments. As for your question 2 and 3:
(Ref. #180)