idaholab / TMAP8

Tritium Migration Analysis Program, Version 8
https://mooseframework.inl.gov/TMAP8/
GNU Lesser General Public License v2.1
15 stars 21 forks source link

Ver 1ka #183

Closed Lee01Atom closed 1 month ago

Lee01Atom commented 2 months ago

(Ref. https://github.com/idaholab/TMAP8/issues/12)

EDIT: for your next PR, @Lee01Atom, you should list the issue number here too, just like I added above.

simopier commented 1 month ago

@Lee01Atom see my emails on how to clean this up. If that doesn't work, let me know.

moosebuild commented 1 month ago

Job Documentation, step Sync to remote on b0b0668 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 1 month ago

Job Coverage, step Generate coverage on b0b0668 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

Lee01Atom commented 1 month ago

@simopier the Test/Test Debug seems to work.

There is still an issue with the Documentation: in the .md file, "comparison_ver-1ka.py" is not found, although it exists in doc/content/verification_and_validation/comparison_ver-1ka.py. Could I be missing something in the automatically generated documentation?

simopier commented 1 month ago

@simopier the Test/Test Debug seems to work.

There is still an issue with the Documentation: in the .md file, "comparison_ver-1ka.py" is not found, although it exists in doc/content/verification_and_validation/comparison_ver-1ka.py. Could I be missing something in the automatically generated documentation?

See a suggestion in my latest review above. Let me know if you're running into issues. By the way, to create the documentation locally, you can do:

conda activate moose
cd ~/projects/TMAP8/doc 
./moosedocs.py build --serve
simopier commented 1 month ago

You are getting:

##########################################################################
ERROR: The following files contain trailing whitespace after applying your patch:
    test/tests/ver-1ka/ver-1ka.i

Run the "delete_trailing_whitespace.sh" script in your $MOOSE_DIR/scripts directory.
##########################################################################