Closed Lee01Atom closed 3 days ago
@Lee01Atom, please update the comment at the top of the page to list the related issue (see what i did on your previous PR).
Job Documentation, step Sync to remote on 5ba0851 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage, step Generate coverage on 5ba0851 wanted to post the following:
Coverage did not change
This comment will be updated on new commits.
You currently get the following error:
##########################################################################
ERROR: The following files contain trailing whitespace after applying your patch:
test/tests/ver-1kb/ver-1kb.i
Run the "delete_trailing_whitespace.sh" script in your $MOOSE_DIR/scripts directory.
##########################################################################
Check both these links out to automatically solve these issues in VSCode:
The heavy test fail is unrelated to this PR.
I'm wondering something: Could you refine the node size (and increase the number of nodes) and see the impact it has on mass conservation? I think we could improve it.
As you do that, make sure to update the documentation accordingly.
I'm wondering something: Could you refine the node size (and increase the number of nodes) and see the impact it has on mass conservation? I think we could improve it.
As you do that, make sure to update the documentation accordingly.
When I increase the number of nodes (e.g., from 100 to 1,000), the percentage of mass variation indeed decreases by a factor of 10. However, the test for ver-1kb_exodus_concentration_jump fails because two elements have midpoints so close that Exodiff cannot distinguish them.
I'm wondering something: Could you refine the node size (and increase the number of nodes) and see the impact it has on mass conservation? I think we could improve it.
As you do that, make sure to update the documentation accordingly.
When I increase the number of nodes (e.g., from 100 to 1,000), the percentage of mass variation indeed decreases by a factor of 10. However, the test for ver-1kb_exodus_concentration_jump fails because two elements have midpoints so close that Exodiff cannot distinguish them.
There are ways to avoid this failure with Exodiff not recognizing that two points are different because they are too close. For example, we can update the length unit of the case so that the number representing the distance is above the exodiff threshold (which is an absolute value without units directly associated with it). or we can use a .exodiff
file to modify the that tolerance and reduce it.
In this case, I think it is reasonable to use 100 nodes in the mesh, and acknowledge in the documentation that the mass variations can be further minimized by using a finer mesh.
(Ref. #12)