search

idaholab / TMAP8

Tritium Migration Analysis Program, Version 8
https://mooseframework.inl.gov/TMAP8/
GNU Lesser General Public License v2.1
15 stars 21 forks source link

Add verification case val-2d #204

Open lin-yang-ly opened 1 month ago

lin-yang-ly commented 1 month ago

(Ref. #12) (Close. #203)

lin-yang-ly commented 1 month ago

@simopier I just completed the validation case val-2d. Just let me know if you have any suggestions!

BTW, the running time of the validation case is still around 9s after I optimized the mesh and time steps. I will continue to find a way to lower the running time, and please let me know if you have any suggestions for that.

moosebuild commented 1 month ago

Job Documentation, step Sync to remote on c87a3a1 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 1 month ago

Job Coverage, step Generate coverage on c87a3a1 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

lin-yang-ly commented 3 weeks ago

@simopier I found a issue on the RMSPE calculation in val-2d, so I fix it in the latest commits. However, the PR met an "TIMEOUT" error from "ver-1c" during the "Test Debug" check. Do I need to do something for "ver-1c" or leave it alone?

simopier commented 3 weeks ago

Definitely leave it alone here.

lin-yang-ly commented 1 week ago

@simopier I updated the heavy tests with coarser mesh to avoid the "heavy test issue" and the RMSPE don't have much difference. Right now, We can use time_step_interval of 20 instead of a strange large number. Also, I clean the commits history and it is ready for review!