search

idaholab / TMAP8

Tritium Migration Analysis Program, Version 8
https://mooseframework.inl.gov/TMAP8/
GNU Lesser General Public License v2.1
15 stars 21 forks source link

New verification standards document #210

Closed chaibhave closed 3 weeks ago

chaibhave commented 3 weeks ago

Creates standards document proposed in #123 . Do not close the issue yet, we need to also go through the existing V&V cases to ensure they are up to the standards.

moosebuild commented 3 weeks ago

Job Documentation, step Sync to remote on 58c92e6 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 3 weeks ago

Job Coverage, step Generate coverage on 58c92e6 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

simopier commented 3 weeks ago

@Lee01Atom and @lin-yang-ly, could you look at this page and tell us if that makes sense to you? It is meant to provide guidelines and set expectations for verification cases. As newer contributors of TMAP8, do you think this could be improved in any way? Is the document missing anything?

Thank you!

chaibhave commented 3 weeks ago

@simopier I think when there's two suggested changes on the same line git doesn't properly merge them. Can you please tell me what change I'm missing?

lin-yang-ly commented 3 weeks ago

Hello @simopier, thanks for asking! All the things in the standards document looks good to me!

Besides, I am thinking about maybe we can add the visualization of the cases with coarse meshes and time steps. Currently, we only verify the results of these coarse cases in "tests", and there is on code in python script to visualize the results of these coarse cases. Thus, we can add a code block in python script to plot the results of coarse cases, demonstrating that they still match the experimental data even with coarse meshes and time steps.

Just let me know your suggestions for the idea!

Lee01Atom commented 3 weeks ago

Hi @simopier, The standards document is very clear to me, and I don’t have any specific changes to propose at the moment. If I come up with any suggestions for improvement later, I’ll be sure to share them!