search

idaholab / moose

Multiphysics Object Oriented Simulation Environment
https://www.mooseframework.org
GNU Lesser General Public License v2.1
1.72k stars 1.04k forks source link

Geochemistry: improve code coverage #17134

Open WilkAndy opened 3 years ago

WilkAndy commented 3 years ago

Reason

The code coverage report, https://mooseframework.inl.gov/docs/coverage/geochemistry/index.html , shows the code coverage is pretty good, but could be improved

Design

Make more tests, revise existing tests, revise existing code.

Impact

More strongly tested code helps user acceptance

loganharbour commented 3 years ago

pretty good

AKA has the most coverage of anything in MOOSE :-)

WilkAndy commented 3 years ago

But i don't want anyone to beat me, do i? Actually, i think this is just because i worry excessively and i'm too much of a perfectionist.

loganharbour commented 3 years ago

ray_tracing is up to 92.4% - I was hoping to catch up, but it looks like I'll have to try harder 😆

WilkAndy commented 3 years ago

Hi @rpodgorney , just letting you know that i'm working on this when i want to have fun