Please Add Pytorch to Be Automatically Installed

idiap / fast-transformers

Pytorch library for fast transformer implementations

1.65k stars 179 forks source link

Please Add Pytorch to Be Automatically Installed #15

Closed maximilianreimer closed 4 years ago

maximilianreimer commented 4 years ago

Hi, I ran into to problem that you need to manually install pytorch before running pip install --user pytorch-fast-transformers. It would be very convenient if pytorch were installed automatically in the setup.py

angeloskath commented 4 years ago

Do you have a suggestion for how we should go about doing this?

Personally, I feel that choosing a PyTorch installation is a significant choice that this library should not be making.

Cheers, Angelos

angeloskath commented 4 years ago

I will close this issue since it is stale and I still think it is not this library's place to install PyTorch.