search

ietf-tools / bibxml-service

Django-based Web service implementing IETF BibXML APIs
https://bib.ietf.org
BSD 3-Clause "New" or "Revised" License
17 stars 19 forks source link

Launching Docker-based development environment locally fails with an error #311

Closed strogonoff closed 2 years ago

strogonoff commented 2 years ago

Describe the issue

The error makes all development problematic due to inability to launch the service locally.

The error happens when container celery is started:

Error response from daemon: failed to initialize logging driver: Unix syslog delivery error

I suspect it may have to do with this part of the Compose file:

    logging:
      driver: "syslog"
      options:
        syslog-address: "${SYSLOG}"

Is there a new dependency that I missed that is required for this to work?

cc @kesara

Code of Conduct

kesara commented 2 years ago

This is another operational change I had to make because we collect logs for monitoring by writing them to an internal syslog daemon.

rjsparks commented 2 years ago

is development configuration separated from deployment configuration in a way that would make this logging configuration easy to isolate?

kesara commented 2 years ago

At the moment syslog configuration is in docker-compose.yml. Running bibxml-service locally for development requires both docker-compose.yml and docker-compose.dev.yml. I think we can overwrite the logging configuration in docker-compose.dev.yml or move syslog logging configuration to another dockerfile for production.

stefanomunarini commented 2 years ago

@kesara have a look at https://github.com/ietf-ribose/bibxml-service/pull/16 . Is this solution acceptable, or did you have anything different in mind?

kesara commented 2 years ago

@stefanomunarini Thanks, that change looks good. When you are ready make a PR against https://github.com/ietf-tools/bibxml-service.

stefanomunarini commented 2 years ago

319 , which contains the fix to this issue, has been merged. Closing this