Pdfized rendering pagination incorrect on first page break

[jimfenton]

What happened?

When rendering an Internet Draft (specifically, draft-ietf-jmap-blob-09) using the pdfized format on the draft's information page, the first page includes, at the bottom, the heading from page 2. The rest of the pages are paginated correctly.

What browser(s) are you seeing the problem on?

Firefox

Code of Conduct

• [X] I agree to follow the IETF's Code of Conduct

[larseggert]

This should be fixed as part of #4082. Note that it also needs https://github.com/ietf-tools/rfc2html/pull/12.

[larseggert]

@jimfenton can you confirm if this is fixed now?

[jimfenton]

@larseggert Has the pdfized format option gone away? I don't see it on the draft information page any more. IIRC, it was basically a rendering of the .txt file into a PDF (with page numbering, headers, and footers). If that option was eliminated for some other reason, then this issue has been overcome by events.

The pdf format looks quite good although without headers, footers, and page numbers that the .txt format has. I looked at draft-ietf-jmap-blob-18, and it looks like maybe the widow/orphan control got out of hand on Section 4.1.2, where there is a page with only the section header followed by a long section of json. But that's probably a separate issue.

[larseggert]

@larseggert Has the pdfized format option gone away? I don't see it on the draft information page any more.

Er, no? See the "pdf" button.

[jimfenton]

I thought there was a separate button, I think called "pdfized", that rendered a PDF that looks like the txt format (with page numbering, headers, and footers). I tried to start my old development version of datatracker to see if it was there, but it doesn't work (I changed laptops in the interim, among other things). But if pdfized went away, or the behavior of the pdf version changed to eliminate the page numbering, etc. then it's OK to call this fixed as OBE.

[rjsparks]

mmm - no - that view is still there, and it's a bug that the button isn't present. The page should be linking to https://datatracker.ietf.org/doc/pdf/draft-ietf-jmap-blob-09.pdf as pdfized. (Unless I've forgotten a decision to stop doing that, but looking at the code in main, I don't immediately see why the button isn't present).

[rjsparks]

I wonder if line 17 below: https://github.com/ietf-tools/datatracker/blob/996e6c2011d8537cdfd2ab5a00599946126f5b87/ietf/templates/doc/document_format_buttons.html#L16-L17 should be {{ label }}, similar to line 19?

[jimfenton]

Seems like it should be {{ label }} so it renders as pdf or pdfized depending on the situation. That explains what happened with the button saying pdf vs. pdfized. But that's separate from the original problem.

Apparently we're rendering pdf now without headers and footers; is that correct? If so, the original issue is moot because it had to do with a spillover of the first page footer.

[larseggert]

If there is real HTML, we PDFize that. If all we have is plaintext, we PDFize the HTMLized plaintext (which has headers and footers). That is online with what the main doc view is doing now.

[rjsparks]

It's the main doc view that we're talking about? I'm having a hard time rationalizing why https://github.com/ietf-tools/datatracker/blob/996e6c2011d8537cdfd2ab5a00599946126f5b87/ietf/doc/utils.py#L1029-L1031 isn't producing an htmlized button on the main view (I think it's because of the above).

[jimfenton]

Didn't we, at one time, have both a pdf and pdfized button? IIRC, the pdfized button converted the txt version (with headers and footers) and the pdf button converted the html (or maybe the source?). Going back to the original issue here, I was referring to spillover from the footer of page 1 onto page 2. That doesn't make sense for conversion of the html into a PDF since the html doesn't have a footer.

I'm probably being a bit old-school here, wanting the document to look like the .txt version. I think it would be ideal if we could make documents render like they show up on the rfc-editor site (when they become an RFC, of course).