search

ietf-tools / www

A customized CMS for the IETF website
BSD 3-Clause "New" or "Revised" License
22 stars 45 forks source link

Expose outgoing mail settings in the Helm chart #411

Open kesara opened 3 months ago

kesara commented 3 months ago

Expose outgoing mail settings in the Helm chart. Probably required to expose:

rjsparks commented 3 months ago

is DEFAULT_FROM_EMAIL already exposed? Do you expect it to need to be different from that?

microamp commented 3 months ago

is DEFAULT_FROM_EMAIL already exposed?

It appears to be.

kubectl exec -it www-wagtail-74bf879bdf-7vm4p --container www -- bash
/app# python
Python 3.12.2 (main, Mar 12 2024, 11:13:18) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from django.conf import settings
>>> settings.DEFAULT_FROM_EMAIL
'donotreply@ietf.org'

It is currently hardcoded in helm/local.py, but can be made configurable, like EMAIL_HOST is.

DEFAULT_FROM_EMAIL = "donotreply@ietf.org"
EMAIL_HOST = os.environ["EMAIL_HOST"]

which will be mail.ietf.org in production?

microamp commented 3 months ago

WAGTAILADMIN_NOTIFICATION_FROM_EMAIL

says

If omitted, Wagtail will fall back to using Django’s DEFAULT_FROM_EMAIL setting.

So, I hope DEFAULT_FROM_EMAIL will be sufficient. Please let me know otherwise.

rjsparks commented 2 months ago

Just expose DEFAULT_FROM_EMAIL instead of WAGTAILADMIN_NOTIFICATION_FROM_EMAIL then.