ifl0w / RandomWallpaperGnome3

Random Wallpapers for Gnome 3
MIT License
176 stars 40 forks source link

Support Gnome 45 #172

Closed Lucki closed 4 months ago

Lucki commented 10 months ago

With Gnome 45 the legacy import system will be dropped completely. Currently, in v3 there are still some legacy imports in the code. We have to check and adapt the remaining bits:

crashbit666 commented 9 months ago

Yeah, I'm waiting for gnome 45 support too.

Lucki commented 9 months ago

I'll take a look at it when it arrives in my distros repositories. I haven't seen anything meaningful pushed since the last merge so I hope there won't clash too much with his local changes.

Lucki commented 8 months ago

This is actually more annoying than expected. The fact that the new resource loading path is different for the background context and the preference window context makes it unnecessary hard to reuse modules across both contexts. /rant

erickwill commented 8 months ago

Guys, is there any way to install this extension in Gnome45? Is there any updated repository with the proper changes to make it work again? Thanks

ifl0w commented 8 months ago

@erickwill your best bet right now is the PR from @Lucki here (it should just works): https://github.com/ifl0w/RandomWallpaperGnome3/pull/176

Unfortunately, I am not able to work on the extension till end of November but I hope to release a new version ASAP in December. Sorry for the inconvenience 😔 ..

erickwill commented 8 months ago

@erickwill your best bet right now is the PR from @Lucki here (it should just works): #176

Unfortunately, I am not able to work on the extension till end of November but I hope to release a new version ASAP in December. Sorry for the inconvenience 😔 ..

In the meantime, I wonder if could you merge these changes made by @Lucki since, as others like me, many love your extension and would like to use it.

ifl0w commented 7 months ago

@erickwill sorry for the late answer!

Just merged Lucki's PR into the WIP_v3.0.0 branch. Feel free to check it out! FYI, I plan to move the WIP branch to development in the next few weeks.

Draky50110 commented 7 months ago

Thanks a lot.

Tried to download code fro 3.0 branch and putting src dir in extension directory but it doesn't not work. Will wait for official release :p

erickwill commented 6 months ago

@erickwill sorry for the late answer!

Just merged Lucki's PR into the WIP_v3.0.0 branch. Feel free to check it out! FYI, I plan to move the WIP branch to development in the next few weeks.

Thanks! Looking forward for the final version! :)

skyghis commented 5 months ago

Just merged Lucki's PR into the WIP_v3.0.0 branch. Feel free to check it out! FYI, I plan to move the WIP branch to development in the next few weeks.

Thanks for the merge. Any news for v3.0.0 release ?

ifl0w commented 5 months ago

@skyghis Pretty close to done and I want to create a release soon (maybe I'll wait for #187 ). I didn't find a lot of time to work on this and I'm sorry for the delayed release.

Also keep in mind, even when I finally release a version here on GH, the extension will have to go through a review on the Gnome website as well. So getting a release on the gnome extensions website might take some additional time.

ifl0w commented 4 months ago

I just created the release for v3.0.0. :tada: Version 3.0.0 supports gnome-shell 45. Therefore, I'm closing this issue! Support for older versions was dropped with this version. Thanks to all contributors for their help and time!

The release will hopefully land on extensions.gnome.org in the next few days/weeks, depending on how long the review takes and whether changes are requested.

Draky50110 commented 4 months ago

I confirm it working with Ubuntu 23.10 + Gnome Shell 45.2.

Tried it downloading and extracting directly last release in .local/share/gnome....