igo95862 / bubblejail

Bubblewrap based sandboxing for desktop applications
264 stars 17 forks source link

feat: detect Vivaldi and Brave #132

Closed boredsquirrel closed 2 months ago

boredsquirrel commented 2 months ago

I installed those browsers to get the desktop entry names

this should detect brave, brave beta, brave nightly and vivaldi stable

igo95862 commented 2 months ago

Hello @boredsquirrel

Unfortunately the array of dot_desktop_path is not very well suited for the similar applications. For example, the default arguments would not be updated to match. It was originally added as a fix for different distros having different desktop entry names.

boredsquirrel commented 2 months ago

hi, so instead every app should have its own rules?

igo95862 commented 2 months ago

hi, so instead every app should have its own rules?

Not necessarily. It's just the current system is not well suited. Maybe with some modifications it can be a good fit.

I will think about it.

boredsquirrel commented 2 months ago

I think it would be great to use the same rules for programs, while using different profiles.

These should need the exact same things, and fixing one woulf fix all.