search

igo95862 / bubblejail

Bubblewrap based sandboxing for desktop applications
264 stars 17 forks source link

Doesnt detect Fedora Chromium #97

Closed boredsquirrel closed 6 months ago

boredsquirrel commented 8 months ago

Output of bubblejail --version

0.8.3

Your distro name and version

Fedora 39 Kinoite

Description

I have Chromium layered (installed as RPM), and it is called chromium-browser for some reason on fedora, which makes bubblejail not only give an error message "no desktop entry found" but even worse block the usage of the chromium preset.

detecting chromium OR

igo95862 commented 8 months ago

Hello @trytomakeyouprivate

Interesting.

By the way is it only the binary that is called chromium-browser or is the desktop entry also called chromium-browser.desktop?

boredsquirrel commented 8 months ago

both the binary and the desktop entry are called chromium-browser

/usr/bin/chromium-browser

/usr/share/applications/chromium-browser.desktop

igo95862 commented 8 months ago

I see. @rusty-snake could probably patch this in his .spec file as this falls under a distro specific quirks.

rusty-snake commented 8 months ago

Fedora, OpenSUSE, Ubuntu/Mint seem to have a chromium-browser.desktop. Some more distros like alpine have at least an additional /usr/bin/chromium-browser binary/symlink. See https://pkgs.org/search/?q=chromium.

Given that, do you still prefer to patch downstream?

igo95862 commented 8 months ago

I decided to check the destkop entry names.

Maybe some kind of quirk of RPM based distros?

rusty-snake commented 8 months ago

RPM based distros and Linux Mint? While Linux Mint is build on top of Ubuntu, they don't use snaps.

Upstream seem to use chromium-browser over chromium https://source.chromium.org/search?q=chromium-browser.desktop

igo95862 commented 8 months ago

I guess it is worth adding support for multiple desktop entries paths for profiles.

For example, Firefox ESR on Debian uses firefox-esr.desktop: https://packages.debian.org/bookworm/amd64/firefox-esr/filelist

igo95862 commented 6 months ago

Should be fixed in 57a8265c778d7b4c1a0af2b3d0d1d41cd1209514. Profiles now support a list of desktop entries and will pick the first found one. I added firefox-esr.desktop and chromium-browser.desktop as alternative names.

igo95862 commented 6 months ago

@boredsquirrel could you give it a test?

I will close this issue for now. If it still can't find the desktop entry feel free to reopen it.