search

igorsantos07 / yii-whoops

Integrates the Whoops library into Yii 1.1.
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

Namespace #2

Open denis-sokolov opened 10 years ago

denis-sokolov commented 10 years ago

Perhaps you'd like to namespace your class. Currently you use a very ambitious WhoopsErrorHandler global name. Perhaps you could namespace it under YiiWhoops\ or IgorSantos\?

igorsantos07 commented 10 years ago

I could, but that's how Yii 1 still works, so there's no need to add namespacing to an environment that usually does not need it. The class name is very clear, as it extends from the framework's CErrorHandler :)

I'll probably think about it later, take a look at #3 and you'll starting to see the need of namespacing. On 12 May 2014 21:43, "Denis Sokolov" notifications@github.com wrote:

Perhaps you'd like to namespace your class. Currently you use a very ambitious WhoopsErrorHandler global name. Perhaps you could namespace it under YiiWhoops\ or IgorSantos\?

— Reply to this email directly or view it on GitHubhttps://github.com/igorsantos07/yii-whoops/issues/2 .