search

igorski / regrader

VST delay plugin where the repeats degrade in resolution
https://www.igorski.nl/download/regrader
MIT License
90 stars 5 forks source link

Problem setting sample rate #6

Closed jpcima closed 4 years ago

jpcima commented 4 years ago

Hello, I have done recent porting work to get this software to work as Linux LV2.

While doing the work, I noticed a problem. The sample rate is defined as static variable in the global header.

Because of being static, compilation units which read and write SAMPLE_RATE are possibly going to address distinct variables. So, assigning sample rate will not have effect on other components, and the DSP will configure itself based on default 44100 Hz.

Such behavior is verifiable of GCC and Clang compilers, about MS I don't know whether it is the case.

igorski commented 4 years ago

It is embarrassing that only now this problem is addressed. This has been tackled in adb3fb81f88e6ab79e7a921324b797ba5ffe2153