igrins / plp

IGRINS pipeline package v3
18 stars 16 forks source link

1D extraction in the .spec.fits file for EXTENDED-ONOFF sources appears to assume nodding on slit #24

Closed kfkaplan closed 10 months ago

kfkaplan commented 12 months ago

I have noticed that for EXTENDED-ONOFF targets, for the qlook (and by extension flexure) branches, that the 1D spectrum in the .spec.fits files appears to not be extracting the spectrum correctly and the extraction hovers around zero counts. I suspect the 1D extraction is incorrectly assuming ABBA nodding of the target on slit. For comparison, summing along the slit axis in the .spec2d.fits files results in the correct 1D extraction. See the attached plot of an H band order from an emission line nebula where summing the order found in the .spec2d.fits file gives the correct extraction for the extended object while the 1D spectrum found in the .spec.fits file appears to be ABBA extracted.

Screenshot 2023-09-05 at 5 58 59 PM

Targets labeled STELLAR-AB or A0V-AB are correctly extracted in 1D so for point sources nodded on the slit, there is no issue here, this only applies to EXTENDED-ONOFF.

leejjoon commented 11 months ago

Thanks. I have pushed the fix for this. Please try the most recent qlook branch and let me know.

kfkaplan commented 11 months ago

I don't see the commit on the qlook branch. Can you push to the remote repo?

leejjoon commented 10 months ago

My apology. I pushed it but with a different branch name. The change was also applied to the qlook branch. So, please check it again.

kfkaplan commented 10 months ago

Okay I merged the new commits in the qlook branch with the flexure branch and reran a night. The extracted 1D spectra for extended-onoff now look nearly identical compared to nansum collapsing the 2D spectrum (as seen in the example). I consider this issue solved and will close it.

Screenshot 2023-10-17 at 1 30 50 PM