igrins / plp

IGRINS pipeline package v3
18 stars 16 forks source link

Sometimes K band only gets 25 orders extracted #29

Open ericasaw opened 6 months ago

ericasaw commented 6 months ago

Noticed this bug or maybe feature in the pipeline from qlook branch onward that makes my life a little harder when comparing the old and new pipeline outputs. Sometimes the new pipeline will throw out the top order in K-band and the final pipeline products will only feature 25 orders instead of 26. I cant find any sort of consistency in how it occurs (ie. in the same night some K band spectra will have 25 orders and some will have 26).

I would prefer if there is a consistent number of orders for all the spectra in both bands (whether that be always chopping of the first order of K band or always keeping the first order).

Do you know where this stems from in the changes you made @leejjoon?

leejjoon commented 3 months ago

I would say the proper way to workaround this would be to read the header and parse the WAT header to figure out which orders of spectra are extracted. The easier workaournd is to specify the range of orders to extract, and this is implemented in the PR #35. Please test the PR and send me any feedback.