search

igrins / plp

IGRINS pipeline package v3
18 stars 16 forks source link

PLP not compatible with python 3.12 #31

Closed kfkaplan closed 3 months ago

kfkaplan commented 5 months ago

I have found that the PLP is not commpatible with Python 3.12. It should run with python 3.11 or below so anyone running into this issue should create a python environment that runs in python 3.11 for running the PLP.

This stems from import imp being depreciated and removed from python v3.12.

This package imp is imported in igrins/igrins_recipes/__init__.py.

Need to implement some sort of solution, like what is discussed in https://discuss.python.org/t/how-do-i-migrate-from-imp/27885/9

kfkaplan commented 3 months ago

PR https://github.com/igrins/plp/pull/37 should fix this. Testing now.

kfkaplan commented 3 months ago

Test was successful. Once the changes are merged with the master branch, I'll close this issue.

kfkaplan commented 3 months ago

PR https://github.com/igrins/plp/pull/37 merged with master branch. This fixes the issue. Closing.