igrr / mkspiffs

Tool to build and unpack SPIFFS images
MIT License
186 stars 91 forks source link

Replacing 'diff --strip-trailing-cr' #51

Closed b0wter closed 6 years ago

b0wter commented 6 years ago

I am converting most of my toolchains to work in docker containers and the linux distro of choice for me is alpine because of it's small size (4mb base image). However, since it uses busy box for the core components there are usually some workaround required to get things to work.

While trying to get this to work in an alpine container I found that diff doesnt support the --strip-trailing-cr parameter. Do you see any difficulties in replacing this with a sed-command and run diff afterwards?

igrr commented 6 years ago

No problem, as long as sed command works with BSD version of sed as well.

igrr commented 6 years ago

Merged #52, thanks!