ihhub / fheroes2

fheroes2 is a recreation of Heroes of Might and Magic II game engine.
https://ihhub.github.io/fheroes2/
GNU General Public License v2.0
2.66k stars 373 forks source link

Main menu, resolution list structure #6543

Open Branikolog opened 1 year ago

Branikolog commented 1 year ago

Preliminary checks

Describe the problem requiring a solution

image

Overall game size (especialy, when we're talking about battle and castle screens) is mostly dependent on image height. Resolutions are sorted according to the image width currently, which makes sometimes rather difficult to select the most comfortable resolution.

Describe the possible solution

I propose to sort available resolutions according to the image height, rahter than image width.

Additional info

No response

Laserlicht commented 1 year ago

Or as a compromise the number of pixels (width x height). Then the aspect ratio is not the determining factor.

Branikolog commented 1 year ago

I personally prefer to watch resolutions sorted regarding the second number. 640x480, 1024x480 and 1920x480 preferably should be placed together, since users (in my personal opinion) after they have chosen the image height (which corresponds overall game size) want the game to fill the entire screen. I think it's logical sort list according image size (from bigger, to smaller) rather than current, since the most part of users tend to complain on UI, and battle/castle size. Currently, If I want to play a game with maximum large battle/castle screens (on x480 resolutions), I have to search for widescreen options somewhere in the middle of the list.

Osmodium commented 1 year ago

I have (as just learning the codebase) looked at adding aspect ratios to the menu (using a GCD calculation based on the width and height), since I always struggle with remembering which w/h combinations equates to my screens aspect ratios 😅. How do you feel about that as a solution? image EDIT: opened an improvement issue on this https://github.com/ihhub/fheroes2/issues/6586

Laserlicht commented 1 year ago

How do you feel about that as a solution?

Good idea! :)