Display aspect ratio in resolution select dialog

[Osmodium]

Preliminary checks

• [X] I've checked that there aren't other open issues on the same topic.

Describe the problem requiring a solution

I never know which resolution uses a certain aspect ratio, also since I change the screen I play on from time to time, and if the resolutions and scales are added dynamically then you might want to know if a resolution would look good on a large variety of monitors.

Describe the possible solution

To show the aspect ratio in the screen resolution dialog would help the player choose a fitting resolution. It could look something like this;

Additional info

I have a working prototype of it here

[oleg-derevenetz]

Hi @Osmodium if you already have an implementation, you are welcome to offer a pull request. I believe this improvement might be really handy (the specific design can be discussed in the process).

[Osmodium]

@oleg-derevenetz I have an implementation, and yea it might not be the prettiest as of now, but I will go ahead and make a pr :)

[Osmodium]

PR opened here https://github.com/ihhub/fheroes2/pull/6587

[oleg-derevenetz]

Hi @Branikolog @zenseii what do you think about this design?

[Branikolog]

Hi, @oleg-derevenetz ! For me personally, the gap between these two values is too large. I prefer them be placed closer to each other. Or adding a line in this gap connecting them. We can also align columns with respect to " x " and " : " being in center.

Or even don't change anything here and simply add this aspect ratio value into info window when we right click on some particular resolution.

[Osmodium]

I would agree that the gap might be too big, however for me to quickly see which resolutions are which ratios is harder if I'd have to right-click each individually. I can see that the format of the lines differ depending on if there is scaling involved, but I'd be happy to make a pass of this where they are aligned closer with a format that would look something like this: Where scale equals 1: 1920 x 1080 (16 : 9) Where scale larger than 1: 1920 x 1080 (16 : 9) (x2) Or other format if you wish :)

[zenseii]

Hi, everyone.

Imo this looks OK. The problem I see with having both (2x) and the aspect ratio in parantheses next to each other is that it could be harder to see the (2x) in a sea of parentheses.

I'm more surprised to see such unusual aspect ratios like 683x384 reported. I am aware that the resolution it refers to, 1366x768, is very common. Should we omit the aspect ratio if it has a three-digit number? Or write something different?

[Osmodium]

I have tried a few different iterations of different layouts. A) Which might be too cramped

B + C) Without and with scale.

D + E) Without and with scale.

In the layouts where the scale is displayed, it might not look so intense when only the scales above 1 is being displayed.

[Laserlicht]

Visually the last variant looks best I think.

[ihhub]

I recommend to use the current implementation in must branch when we show scaling only for x2 and higher and add proportions on the right side. We need to remember that visual information must be minimal and having x1 everywhere can easily lead to missing x2 sign.

[Osmodium]

@ihhub yes, the x1 was just for reference since I don't have any x2 or above in my list.