prohibit spaces in logo file name

[holta]

Thanks to @tim-moody for fixing this!

Quick Background:

• https://github.com/iiab-share/js-menu-files/blob/master/menu-defs/en-SSSec.json used to contain "logo_url": "SS MoE logo.png", — leading to...

# /usr/bin/iiab-sync-menu-defs
/usr/bin/wget -c https://raw.githubusercontent.com/iiab-share/js-menu-files/master/images/SS%20MoE%20logo.png -O /library/www/html/js-menu/menu-files/images/SS MoE logo.png
--2023-12-20 18:13:36--  https://raw.githubusercontent.com/iiab-share/js-menu-files/master/images/SS%20MoE%20logo.png
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 185.199.108.133, 185.199.109.133, 185.199.110.133, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|185.199.108.133|:443... connected.
HTTP request sent, awaiting response... 416 Range Not Satisfiable

    The file is already fully retrieved; nothing to do.

--2023-12-20 18:13:37--  http://moe/
Resolving moe (moe)... failed: Temporary failure in name resolution.
wget: unable to resolve host address ‘moe’
--2023-12-20 18:13:41--  http://logo.png/
Resolving logo.png (logo.png)... failed: Name or service not known.
wget: unable to resolve host address ‘logo.png’
Traceback (most recent call last):
  File "/opt/admin/cmdsrv/scripts/sync_menu_defs.py", line 38, in <module>
    adm.write_other_menu_item_def_files(menu_item_def)
  File "/usr/lib/python3/dist-packages/iiab/adm_lib.py", line 232, in write_other_menu_item_def_files
    wget_menu_item_def_file_from_repo(response_dict['download_url'], CONST.js_menu_dir + 'menu-files/images/' + icon_file)
  File "/usr/lib/python3/dist-packages/iiab/adm_lib.py", line 246, in wget_menu_item_def_file_from_repo
    outp = subprocess.check_output(cmd, shell=True)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/subprocess.py", line 466, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '/usr/bin/wget -c https://raw.githubusercontent.com/iiab-share/js-menu-files/master/images/SS%20MoE%20logo.png -O /library/www/html/js-menu/menu-files/images/SS MoE logo.png' returned non-zero exit status 4.

• Someone helped patch up en-SSSec.json (South Sudan Ministry of Education?) an hour ago: https://github.com/iiab-share/js-menu-files/commit/9753fb60b4aa3043234f691c6c214396dee52ee6

• Logo https://github.com/iiab-share/js-menu-files/blob/master/images/Citadel%20Logo.PNG has a similar problem (contains a URL-encoded space) but appears to no longer matter, as no .json menudef refers to this logo.

[holta]

@tim-moody consider deleting "illegal filename" logo: https://github.com/iiab-share/js-menu-files/blob/master/images/SS%20MoE%20logo.png ...as it was auto-copied 2h ago to: https://github.com/iiab-share/js-menu-files/blob/master/images/SS_MoE_logo.png

Likewise consider moving this 2nd "illegal filename" logo: https://github.com/iiab-share/js-menu-files/blob/master/images/Citadel%20Logo.PNG ...to: https://github.com/iiab-share/js-menu-files/blob/master/images/Citadel_Logo.PNG

[holta]

FYI @tim-moody cleaned up the menudef logo repo, deleting both above files: 🧹

https://github.com/iiab-share/js-menu-files/commit/0d22d94b4f457c372339156e221c8ff9c204aaff