search

iiasa / ixmp

The ix modeling platform for integrated and cross-cutting scenario analysis
https://docs.messageix.org/ixmp
Apache License 2.0
38 stars 112 forks source link

Allow passing string to to_jlist (converting to singleton list) #351

Closed zikolach closed 4 years ago

zikolach commented 4 years ago

How it was working before?

codecov[bot] commented 4 years ago

Codecov Report

Merging #351 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   95.79%   95.79%           
=======================================
  Files          45       45           
  Lines        4878     4880    +2     
=======================================
+ Hits         4673     4675    +2     
  Misses        205      205
Impacted Files Coverage Δ
ixmp/backend/jdbc.py 95.13% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59e99e4...5393ec4. Read the comment docs.

khaeru commented 4 years ago

For posterity: this PR was to address errors like the following, that appeared due to changes between JPype1 0.7.5 and 1.0:

TypeError: No matching overloads found for java.util.LinkedList.addAll(str), options are:
        public boolean java.util.LinkedList.addAll(int,java.util.Collection)
        public boolean java.util.LinkedList.addAll(java.util.Collection)