Closed khaeru closed 4 years ago
Merging #371 into master will decrease coverage by
0.0%
. The diff coverage is100.0%
.
@@ Coverage Diff @@
## master #371 +/- ##
========================================
- Coverage 96.8% 96.8% -0.1%
========================================
Files 46 46
Lines 5255 5253 -2
========================================
- Hits 5088 5086 -2
Misses 167 167
Impacted Files | Coverage Δ | |
---|---|---|
ixmp/testing.py | 78.2% <100.0%> (-0.2%) |
:arrow_down: |
It was necessary to work around jupyter/nbclient#85; this was done according to https://github.com/jupyter/nbconvert/issues/1372#issuecomment-691596163. The workaround should be removed once that issue is fixed in a version of nbclient ≥ 0.5.1.
run_notebook()
used the built-in Pythonsubprocess
module to run tutorial and test notebooks, write the results to a file, and then read the finished notebook. This process recently began to cause test & CI failures, e.g. in #370.The Jupyter ecosystem now has a first-class package
nbclient
that executes notebooks programmatically; this PR:nbformat
withnbclient
as a requirement for the 'tests' extra set. (nbclient
itself depends onnbformat
.)ci/
directory, it was not being detected by the Codecov CLI tool.How to review
PR checklist