iiasa / ixmp

The ix modeling platform for integrated and cross-cutting scenario analysis
https://docs.messageix.org/ixmp
Apache License 2.0
38 stars 112 forks source link

Always read notebooks as UTF-8 in ixmp.testing.run_notebook() #372

Closed khaeru closed 4 years ago

khaeru commented 4 years ago

Some message_ix notebooks (see iiasa/message_ix#402) are in UTF-8; this ensures they are read as such, even on Windows.

How to review

Note that the CI checks all pass.

PR checklist

Hotfix; N/A.

codecov[bot] commented 4 years ago

Codecov Report

Merging #372 into master will increase coverage by 0.0%. The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master    #372   +/-   ##
======================================
  Coverage    96.8%   96.8%           
======================================
  Files          46      46           
  Lines        5253    5253           
======================================
+ Hits         5085    5086    +1     
+ Misses        168     167    -1     
Impacted Files Coverage Δ
ixmp/testing.py 78.2% <100.0%> (ø)
ixmp/utils.py 96.1% <0.0%> (+0.4%) :arrow_up: