Closed khaeru closed 3 years ago
Merging #396 (05352ef) into master (95a5ca8) will increase coverage by
0.0%
. The diff coverage is100.0%
.
@@ Coverage Diff @@
## master #396 +/- ##
======================================
Coverage 96.8% 96.9%
======================================
Files 46 46
Lines 5337 5339 +2
======================================
+ Hits 5171 5174 +3
+ Misses 166 165 -1
Impacted Files | Coverage Δ | |
---|---|---|
ixmp/reporting/__init__.py | 95.0% <100.0%> (-0.1%) |
:arrow_down: |
ixmp/reporting/computations.py | 98.8% <100.0%> (+<0.1%) |
:arrow_up: |
ixmp/reporting/utils.py | 97.3% <100.0%> (+1.4%) |
:arrow_up: |
Two small issues spotted while working on MESSAGEix-Transport:
computations.ratio()
was triggering some odd behaviour in pint:Despite the effort of
collect_units()
to ensure units are from the same registry, things like this would happen:Note the different classes. The explicit re-instantiation prevents this.
How to review
Note that the CI checks all pass.
PR checklist