Closed glatterf42 closed 1 month ago
Attention: Patch coverage is 71.59091%
with 25 lines
in your changes are missing coverage. Please review.
Project coverage is 95.6%. Comparing base (
4207f5c
) to head (4913c24
). Report is 1 commits behind head on main.
Not sure why codecov/patch registers a diff hit, we test the same functions as before. So I'm fine with the hit if that comes from additional lines that reduce complexity. I'll rebase to exclude the TEMPORARY
commit and merge once the tests pass (again).
Closes #804. This PR temporarily enables the pandas Copy-on-Write behaviour that will become standard with pandas 3.0. With this, I ran all tests locally to study the warnings we would get from this: only two files were affected,
add_year/__init__
andmacro
. Then, I fixed all of these warnings as suggested in the migration guide, so we might be good with this repo (and all underlying ixmp functions called from the test suite here) :)How to review
TEMPORARY
commit to avoid enabling pandas CoW for all users already.PR checklist