search

iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
991 stars 552 forks source link

Name highlighting issues #119

Closed yoshimo closed 11 years ago

yoshimo commented 11 years ago

Is it intended that a (hostile) @playername mention public channel is also displayed in the faction channel ? Looks rather weird and doesn't belong there

also now that we have @playername can we still have highlights of " playername " playername," and "playername:" and make those that are not our own colored in the faction color?

jonatkins commented 11 years ago

The processing of @name highlights is done on the ingress servers. we just take the name/team data and highlight as it describes.

Adding highlights for any player name, manually parsing the strings, is likely to be slow.

We could highlight mentions of your own name only. We used to do this, before @name highlights were handled on the servers.

jonatkins commented 11 years ago

as for your first point - does #121 explain what you're seeing?

yoshimo commented 11 years ago

My faction tab looks like this Highlighted Timestamp enemyplayername: @myname "how are you doing"
Highlighted Timestamp friendlyplayername: @myname "plans for tonight?"
normal Timestamp friendlyplayer: "portal in the seventh street under attack guys!"

jonatkins commented 11 years ago

can you try it on the standard intel site, with IITC disabled, to see if it happens the same there? If so, it's an issue with the backend - and you should probably report a bug to Niantic.

jonatkins commented 11 years ago

looks like Niantic had changed things in the backend. Now, both @mentions of yourself, plus "your X on Y was destroyed by Z" are sent by the server on both the public and faction channels. In addition to the faction "[secure]" tag was added to the faction messages in the faction channel.

f48aca886461a9dc080eba2831616115539df572 changes things to make more sense in this area - now public @mentions are hidden from the faction tab - and if things do change to let them through in future they'll be tagged with [public]