iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
989 stars 552 forks source link

Images should use https where possible #126

Closed hastarin closed 11 years ago

hastarin commented 11 years ago

Images hosted on the Google/Panoramio servers can be retrieved via https with a simple change to two files. This will be the majority of portal images displayed.

https://www.dropbox.com/s/pzuffqmmwk3lu7h/imagehttps.diff

EDIT: Updated patch to include Panoramio servers.

jonatkins commented 11 years ago

There were definite issues with this in the past - in fact, a change along these lines was specifically reverted back when breunigs hosted IITC due to the issues caused.

Ideally the backend servers should just return https URLs for images when requests come over https (or return both http and https URLs and let the script decide which to use). But it doesn't. I don't think Niantic will help with feature requests here though.

I'm still not convinced there's much point to this, but with the following modifications I'll accept it: