iitc-project / ingress-intel-total-conversion

ingress.com/intel total conversion user script with some new features. Should allow easier extension of the intel map.
http://iitc.jonatkins.com/
ISC License
989 stars 552 forks source link

Portal Remembererer #431

Closed vita10gy closed 11 years ago

vita10gy commented 11 years ago

If it was feasible to do (it might take so long to check it's not worth it) would a change (or plugin) that remembered where portals you've seen are, so it can add them as a layer if they otherwise don't make, it be something that would be merged into the master?

I'm picturing them showing up as gray dots, no info on them, click to zoom (and open on right, if possible). So no scanning, no spoofing zoom distances so level one portals show up just fine from 100 miles out.

Just a simple "you know there's a portal here because you, personally, have already found it by legitimate means" marker.

Seems like it would be really helpful, but it also seems borderline not ok, so I'd like some feedback before I waste my time.

vita10gy commented 11 years ago

It might be a totally moot point if we "should" anyway, cause I think I might have to check every single portal you've ever seen against the current window, and what's showing, which could get way out of hand fast.

jonatkins commented 11 years ago

We already have two 'bookmark/favourite' plugins (one for map views and portals, another submitted earlier for just portals - we should probably drop one of them).

Adding a layer to these to display bookmarked portals on the map would be a good addition.

vita10gy commented 11 years ago

Well, this wouldn't be a bookmarking process, at least from the user's perspective. It would just remember all you've found, and show them on the map when they aren't otherwise. Portals are popping up so fast that some are falling into the cracks, it would be cool to make portals you've already located be more permanent fixtures. So say you saw a portal on your map when it was level 5, but it's since rotted to unclaimed, it would now show as gray in that location at all zoom levels > all. (But again, there would be no spoofing anything, or scanning. Just location remembering, if you wanted to see if that portal was unclaimed vs level 1, current energy level, etc, you'd have to zoom in on it enough to find out.) We need the live data to know the live stats/game state, we don't have to completely "forget" there exists a portal where we were just showing one 3 seconds ago just because we don't know the state of the resonators on it at the higher zoom level.

Also, I'm not sure if I'm an idiot or not, but I installed those bookmark plugins to see what they did, and I have no idea what, if anything, they're doing. One pops up a window that seems to do nothing except cause the page to refresh with clicking +Map, and the other remembers to fill in a blue checkbox the next time you manually find that portal. What am I missing there?

jonatkins commented 11 years ago

Ah - so remember all portals ever viewed - then show the remembered coordinates when it's not in the detail level supplied by the server - yes?

If so - then no. From a practical standpoint we'd be storing massive amounts of data if a user viewed a dense area. Likely to hit browser storage limits after viewing a few large cities. And it doesn't feel to me like the right thing to do either.

hybrid2102 commented 11 years ago

vita10gy, what your statement "portals you've already located" means? In other words, IITC should automatically remeber located portals (1) or waiting for an user input (2)? if 1) I agree with jonatkins last post elseif 2) You can use "Bookmarks for maps and portals"

B4M&P usage: you can save a portal clicking the star in the portals info (near title) or you can save an area of the map by inserting a title in the textbox (left of +Map button) and then clicking +Map. You can also create folders (again, title in textbox and then +Folder button)

edit: you can accomplish 2) also with the use of Draw plugin - just drop a marker

vita10gy commented 11 years ago

I meant 1. Just wondering how people felt about it from a more "ethical" POV, I was going to save "is it feasible" for later.

jonatkins commented 11 years ago

From the "ethical" point of view - I have to say no. I can't put in words exactly why, but it just feels very wrong.