make shortcut work in "Searching, PDF Reading & Note-Taking in Add Dialog" dialog named "Edit Note"

[Laern2Do]

hi there,

im running into problem opening the tag dialog [ctrl +t, d] for "persistent editor" and "searching pdf reading note-taking in add dialog" add-ons

in "searching pdf ..." the little editor where note can be edited wont open the tag dialog. however, for both above-mentioned add-on [ctrl +t, a] will work just fine.

also, the browser editor and the default editor [reviewer > (e)] is able to trigger this tag-dialog just fine

let me know if you can make head or tail of this :). thx a ton!

anki ver. 2.1.26. window 10

[ijgnd]

I just tried in 2.1.26

• "extended_tag_edit_add_dialog" combined with "Persistent editor": "Ctrl+t,d" does NOT work.
• Whereas "searching pdf reading note-taking in add dialog" works with my "extended_tag_edit_add_dialog".

1. Disable "searching pdf reading note-taking in add dialog" and restart Anki: Does "ctrl+t,d" work now?
2. Then: Disable "Persistent Editor", reenable "searching pdf reading note-taking in add dialog": Does "ctrl+t,d" work now?
3. If it still doesn't work: Disable all add-ons except for my "extended_tag_edit_add_dialog" and restart. Does "ctrl+t,d" work now? If so the problem is a conflict with another add-on. Then enable half of the disabled add-ons restart Anki and try again. Repeat this cycle of enabling and disabling a few times until you found the conflict: Then tell me which add-on doesn't work with my "extended_tag_edit_add_dialog"
4. Could you share this: from the main window click on Help->About. In the window that opens click the "Copy Debug Info" Button and share the copied text.

[Laern2Do]

"Whereas "searching pdf reading note-taking in add dialog" works with my "extended_tag_edit_add_dialog".

the extended tag edit/add dialog does work with "searching pdf...". however, when you switch to small edit window [clicking on the "pen" symbol on the note result], "ctrl + t, d" does NOT work. It will work in the "larger" add/edit window with the "pdf search.." add-on

1. "ctrl +t, d" work normally. it does not work with the "small" edit window from search result [via clicking on the pen]
2. persistent editor is disable. "ctrl + t, d" work normally. it does not work with the "small" edit window from search result [via clicking on the pen]
3. "ctrl +t, d" work when all add-on disable. it does not work with 1, 2 and main concern above

thank you!

Anki 2.1.26 (70784154) Python 3.8.0 Qt 5.14.1 PyQt 5.14.1
Platform: Windows 10
Flags: frz=True ao=True sv=2
Add-ons, last update check: 2020-09-25 08:01:31

===Add-ons (active)===
(add-on provided name [Add-on folder, installed at, version, is config changed])
Add Hyperlink ['318752047', 2020-07-29T15:37, 'None', '']
Advanced Browser ['874215009', 2020-04-22T17:45, 'None', mod]
BetterSearch ['1052724801', 2020-09-13T04:54, 'None', mod]
BetterTags ['bettertags', 2020-04-28T10:40, 'None', '']
Clickable Tags v11 ['380714095', 2020-03-22T08:56, 'None', '']
Cloze Overlapper ['cloze_overlapper', 2019-02-01T06:37, 'None', '']
Create Filtered Deck from the Browser ['861263371', 2017-08-29T13:57, 'None', '']
Custom Background Image and Gear Icon ['1210908941', 2020-04-17T16:38, 'None', mod]
Customize Sidebar ['1988760596', 2020-01-15T15:01, 'None', mod]
Extended Tag AddEdit Dialog ['1135507717', 2020-06-30T08:46, 'None', mod]
Fastbar- with nightmode support ['46611790', 2020-03-20T09:34, 'None', '']
High Yield Tags ['1918380616', 2020-06-30T15:35, 'None', mod]
Hint Hotkeys ['1844908621', 2017-08-29T13:53, 'None', '']
Image Occlusion Enhanced ['1374772155', 2020-04-28T12:45, 'None', '']
Leaderboard ['41708974', 2020-07-13T14:24, 'None', mod]
Life Drain Extra - Game Over Message Gamification ['1029714726', 2020-04-01T17:44, 'None', '']
Life Drain ['715575551', 2020-08-13T08:25, 'None', '']
Mini Format Pack ['295889520', 2019-12-04T00:44, 'None', mod]
Persistent Editor ['1686259334', 2020-08-03T08:17, 'None', '']
Pretzel Logic Retention Benchmarking ['1168065472', 2020-04-24T22:13, 'None', mod]
Progress Bar ['2091361802', 2019-11-16T16:36, 'None', '']
Quick Field Navigation ['734297936', 2019-12-29T20:24, 'None', '']
ReMemorize Rescheduler with sibling and logging v140 ['323586997', 2020-04-17T02:07, 'None', mod]
Rebuild All  Empty All for Anki 21 ['1810938259', 2018-07-19T23:40, 'None', '']
Refocus Card when Reviewing 21 ['1642550423', 2018-09-19T09:14, 'None', '']
Review Heatmap ['review_heatmap', 2020-04-30T08:23, 'None', '']
Review Hotmouse ['1928346827', 2020-05-26T03:22, 'None', mod]
Searching PDF Reading  Note-Taking in Add Dialog ['1781298089', 2020-09-25T02:11, 'None', mod]
Spelling Police ['1410276506', 2020-03-02T20:13, 'None', mod]
Symbols As You Type ['2040501954', 2020-04-30T09:32, 'None', '']
Symbols ['1461102936', 2019-11-16T16:38, 'None', mod]
The KING of Button Add-ons ['review_buttons', 2020-03-20T09:34, 'None', mod]
add-on dialog searchfilter bar ['561945101', 2020-05-08T08:16, 'None', '']
copy note contents to new Add window from Browser Reviewer Add EditCurrent ['759018284', 2019-10-13T08:19, 'None', mod]

===IDs of active AnkiWeb add-ons===
1029714726 1052724801 1135507717 1168065472 1210908941 1374772155 1410276506 1461102936 1642550423 1686259334 1781298089 1810938259 1844908621 1918380616 1928346827 1988760596 2040501954 2091361802 295889520 318752047 323586997 380714095 41708974 46611790 561945101 715575551 734297936 759018284 861263371 874215009

===Add-ons (inactive)===
(add-on provided name [Add-on folder, installed at, version, is config changed])

[Laern2Do]

I did another test where i disable all add-ons but keeping "searching PDF reading note-taking in add dialog" and "extended tag add/edit dialog" enable. the issue is still there where "ctrl+t, d" will not trigger the tag dialog inside the smaller edit window in "searching PDF..." add on

again, thank you so much for looking into this :)

[ijgnd]

Now I understand the problem with "searching PDF reading note-taking in add dialog". To make my add-on work in fonol's "Edit Note" window I need to modify my add-on. Since I don't use "searching PDF ..." this will take some time.

temporary workaround: You can open the tag window from the context menu with your mouse.

technical note: the window "Edit Note" from "searching pdf ..." loads an instance of aqt.editor.Editor but I didn't hook into the loading of aqt.editor.Editor. I have this note in my source code: "addHook("setupEditorShortcuts", SetupShortcuts) doesn't work when editor is not focused, e.g. if focus is on tag line. So using an editor shortcut here is bad." source.

So I wrapped AddCards.__init__, EditCurrent.__init__, and used addHook("browser.setupMenus").

[Laern2Do]

Awesome, thx you for the suggested work around :). hopefully when the enhancement come around, it will incorporate persistent editor as well.

Thx again!

[ijgnd]

I keep this open to remind me.

About the persistent editor problem see: #5