search

ikemen-engine / Ikemen-GO

An open-source fighting game engine that supports MUGEN resources.
https://ikemen-engine.github.io
Other
696 stars 124 forks source link

Break the Targets bonus game issues on Ikemen GO v0.99.0-rc.4 #1444

Open WF4123 opened 11 months ago

WF4123 commented 11 months ago

Describe the bug

I tried out a bonus game called "Break the Targets" by NeoKamek on Ikemen GO v0.99.0-rc.4. Some people never tested the old piece from Winmugen era on Ikemen GO builds, but it's kinda really buggy at all. Previously I tested out on v0.98.2 after ending the bonus game, the results are absent (actually disappeared) while breaking the targets. Now on v0.99.0-rc.4, it was broken, but playable.

To Reproduce

  1. Download Break the Targets
  2. Start up the Break the Targets bonus game, control the fighter to break them
  3. When hitting the first target, the next target comes off the bottom and appears multiply when breaking. The timer is literally broken, when causing to break more targets, which it's disappeared, and then goes back on screen. Also one more thing for timer about 30 seconds to 28 seconds from start of the game.

Expected behavior

No response

Screenshots / Video

https://github.com/ikemen-engine/Ikemen-GO/assets/66336727/7bb90227-6687-4c52-9dda-0ca7e50b53d7

Engine Version (or source code date)

v0.99.0-rc.4

Operating system

Windows

Extra context or search terms

No response

WF4123 commented 10 months ago

Odd reason: when I break all of the targets unless it's not permanent during bonus game, it doesn't seems like appearing, also for the timer that it's gone, and never ends well.

potsmugen commented 10 months ago

This bug happens every time the bonus game tries to block. It has to do with how Ikemen 0.99 handles blocking. This char uses an unconventional way to disable blocking instead of AssertSpecial, and the safeguards it has don't cover all scenarios.

We could fix this bug for this char, but I think it'd have a negative impact in every other character. The way blocking is handled was changed to fix bigger issues than this one.

To make the bonus work properly in Ikemen you can add this under [Statedef -2]:

[State -2, Fix] type = AssertSpecial trigger1 = 1 flag = nohardcodedkeys