Survival mode different from Mugen

[potsmugen]

Describe the bug

In Mugen, during Survival mode the round number will go up. In Ikemen, the match number will go up. In addition, RoundsExisted will increment in Mugen but always return 0 in Ikemen.

This is relevant because codes made to work in Mugen Survival will not work in Ikemen.

To Reproduce

1. Add this to KFM

   [State -2, Debug]
   type = displaytoclipboard
   trigger1 = 1
   text = "Roundno = %d Matchno = %d Rounds Existed = %d"
   params = roundno, matchno, roundsexisted
   ignorehitpause = 1

2. Play Survival in either engine

Expected behavior

Same as Mugen.

Screenshots / Video

Mugen 1.1

Ikemen GO

Engine Version (or source code date)

17/02/2024

Operating system

Windows

Extra context or search terms

No response

[K4thos]

This one is intentional. Ikemen Survival works a bit differently than Mugen. It allows stages to be changed between matches, can have more than one round (via Lua edit), supports a finite amount of matches via survival.maxmatches in select.def, garbage collects between matches (mugen can get out of memory after enough rounds) etc. Overall more flexible. The matchno trigger works as you would expect, and roundno+roundexisted returning the actual round number (if more than one is set) is also an improvement and allows us to reuse the same code as in other modes (AI ramping etc.).

We could add exceptions for what these triggers return in survival only but on the other hand it's easy to reliably detect the mode via the gamemode trigger from CNS, and the backward compatibility issue here seems like a very minor thing. Opinions?

[potsmugen]

I see. In that case incrementing matches instead of rounds does make sense. I still think RoundsExisted should increment as well, though, on the basis that it's the entire point of the trigger.