False lock error notification

[iRonin]

I've been getting false lock error notifications (see #93) when the lock is not used (only the status is being checked):

Here is an example log:

[2018-10-2 13:29:52] [Delayed front door lock] Starting the Timer.
[2018-10-2 13:30:22] [Delayed front door lock] Time is Up!
[2018-10-2 13:30:22] [FibaroHC2] Getting value from device:  24  parameter: Contact Sensor State
[2018-10-2 13:30:22] [FibaroHC2] Setting value to device:  47  parameter: Lock Target State
[2018-10-2 13:30:22] [FibaroHC2] Command:  secure, value: 0, to: 47
[2018-10-2 13:30:28] [FibaroHC2] Updating value for device:  47  parameter: Lock Current State, value: true
[2018-10-2 13:30:28] [FibaroHC2] Updating value for device:  47  parameter: Lock Target State, value: true
[2018-10-2 13:57:47] [FibaroHC2] Updating value for device:  47  parameter: Lock Current State, value: false
[2018-10-2 13:57:47] [FibaroHC2] Updating value for device:  47  parameter: Lock Target State, value: false
[2018-10-2 13:59:42] [FibaroHC2] There was a problem setting value to Lock:  47
[2018-10-2 14:00:35] [Delayed front door lock] Starting the Timer.
[2018-10-2 14:00:43] [FibaroHC2] Sent event:  hb_fhc2_lock_error, to: xxx, for 47
[2018-10-2 14:01:05] [Delayed front door lock] Time is Up!
[2018-10-2 14:01:05] [FibaroHC2] Setting value to device:  47  parameter: Lock Target State
[2018-10-2 14:01:05] [FibaroHC2] Command:  secure, value: 0, to: 47
[2018-10-2 14:01:11] [FibaroHC2] Updating value for device:  47  parameter: Lock Current State, value: true
[2018-10-2 14:01:11] [FibaroHC2] Updating value for device:  47  parameter: Lock Target State, value: true
[2018-10-2 14:12:30] [FibaroHC2] Getting value from device:  47  parameter: Lock Current State
[2018-10-2 14:26:31] [FibaroHC2] There was a problem setting value to Lock:  47
[2018-10-2 14:26:32] [FibaroHC2] Sent event:  hb_fhc2_lock_error, to: xxx, for 47

You can see that the lock was successfully locked at 13:30 but then at 14:00 and 14:26 there was a lock error notification sent - yet the lock has not been used. I think the problem may be when the lock is being locked when it's already locked (if this makes sense).

[ilcato]

Are you able to reproduce the problem whenever you want?

[iRonin]

No, I’m not. It happens from time to time, like last Tuesday it happened 3 times at different time, or I can see there were cases of two alerts in the same minute. It happens maybe once a month, always when the lock is locked.

[ilcato]

I fix a problem with lock command via Siri. It is in the last commit. It can be related to this.

[ilcato]

@iRonin, can you test it with latest 2.2.1 version?

[iRonin]

So far, so good 👌🏻

[ilcato]

Please, close the issue when you are confident.