Open MindaugasRam opened 5 years ago
Can you enable debug mode of Homebridge?
Ok I will.
Do you think this might be related?
https://github.com/nfarina/homebridge/issues/1461 On Sun, Mar 10, 2019 at 9:29 PM ilcato notifications@github.com wrote:
Can you enable debug mode of Homebridge?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-471336124, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6ZiHLejJ-2TQbp4VKTzof3BqEtbH8ks5vVV0QgaJpZM4ap3Dj .
I’m using the standard types. Let’s see the logs.
Il giorno 11 mar 2019, alle ore 06:03, carlittoer notifications@github.com ha scritto:
Ok I will.
Do you think this might be related?
https://github.com/nfarina/homebridge/issues/1461 On Sun, Mar 10, 2019 at 9:29 PM ilcato notifications@github.com wrote:
Can you enable debug mode of Homebridge?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-471336124, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6ZiHLejJ-2TQbp4VKTzof3BqEtbH8ks5vVV0QgaJpZM4ap3Dj .
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-471405445, or mute the thread https://github.com/notifications/unsubscribe-auth/ABM7-gAhgTry4rKhpVmldeGSXHxzTz1Fks5vVeO2gaJpZM4ap3Dj.
Can I send you this info somewhere else ? It contains sensitive information.
On Mon, Mar 11, 2019 at 8:01 AM ilcato notifications@github.com wrote:
I’m using the standard types. Let’s see the logs.
Il giorno 11 mar 2019, alle ore 06:03, carlittoer < notifications@github.com> ha scritto:
Ok I will.
Do you think this might be related?
https://github.com/nfarina/homebridge/issues/1461 On Sun, Mar 10, 2019 at 9:29 PM ilcato notifications@github.com wrote:
Can you enable debug mode of Homebridge?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-471336124 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AsX6ZiHLejJ-2TQbp4VKTzof3BqEtbH8ks5vVV0QgaJpZM4ap3Dj
.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-471405445>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ABM7-gAhgTry4rKhpVmldeGSXHxzTz1Fks5vVeO2gaJpZM4ap3Dj .
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-471414251, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6ZpPbNCXgmXL6X7ZwdzWyjuRFL9blks5vVfEggaJpZM4ap3Dj .
Thank you! Now I am very happy, works like a charm!
@MindaugasRam, did you try the commit of this morning?
After looking at @carlittoer logs I made a change that allow the query of the lock status only after a period of 2 seconds.
Yes I replaced all the fix 136 files. And it works. When the command is completed it takes like 1 sec and siri confirms that it’s done.
Would you mind to test with a delay of 1 second instead of 2?
Yes I could do that. Where to change?
in getFunctions.js row 40 and 41
after changing to 1 both values, it gives that error.
Changed back to 2 and happy days again. So I'd say just leave like that and it is perfect. If someone had Danalock v3 (it responses faster), might try with 1. But for v2 it is ok
Ok, will wait for @carlittoer test tonight.
On it right now On Tue, Mar 12, 2019 at 7:03 PM ilcato notifications@github.com wrote:
Ok, will wait for @carlittoer https://github.com/carlittoer test tonight.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-472091176, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6Zip1MoxaoUX6sA3XdiB6zjDETRRWks5vV937gaJpZM4ap3Dj .
I am getting this :
[2019-3-12 17:07:30] [FibaroHC2] Getting value from device: 200 parameter: Lock Current State
[2019-3-12 17:07:33] [FibaroHC2] Getting value from device: 200 parameter: Lock Target State
[2019-3-12 17:07:39] [FibaroHC2] Updating value for device: 268 parameter: Motion Detected, value: true
[2019-3-12 17:07:39] [FibaroHC2] Error fetching updates: TypeError: getFunction.call is not a function
at Poller.manageValue
(/usr/local/lib/node_modules/homebridge-Fibaro-HC2/dist/pollerupdate.js:104:33)
at updates.changes.map
(/usr/local/lib/node_modules/homebridge-Fibaro-HC2/dist/pollerupdate.js:39:30)
at Array.map (<anonymous>:null:null)
at platform.fibaroClient.refreshStates.then
(/usr/local/lib/node_modules/homebridge-Fibaro-HC2/dist/pollerupdate.js:37:33)
at <anonymous>:null:null
at process._tickCallback (internal/process/next_tick.js:118:7)
anything I need to do ?
On Tue, Mar 12, 2019 at 7:06 PM charles.hajj@gmail.com < charles.hajj@gmail.com> wrote:
On it right now On Tue, Mar 12, 2019 at 7:03 PM ilcato notifications@github.com wrote:
Ok, will wait for @carlittoer https://github.com/carlittoer test tonight.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-472091176, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6Zip1MoxaoUX6sA3XdiB6zjDETRRWks5vV937gaJpZM4ap3Dj .
@carlittoer, found the problem. @MindaugasRam, did you disabled poller update? You should receive the same error.
ok, @carlittoer can you update also pollerupdate.js ?
I didn’t checked logs, as it was working fine. When get back will check.
No, I didn’t disabled it.
With the latest change, I noticed that from the home app (no siri) if you lock / unlock, it automatically changes the state of the device even before the doorlock has performed the operation. So i reverted back to the old code in setFunctions and now I see a spinner until the physical lock finishes.
this.command(action, [0], service, IDs); characteristic.setValue(value, undefined, 'fromSetValue');
I also changed the delays in getFunctions to the below :
[(new hapCharacteristic.LockCurrentState()).UUID, { "function": this. getLockCurrentState, "delay": 5 }], [(new hapCharacteristic.LockTargetState()).UUID, { "function": this. getLockCurrentState, "delay": 0 }],
I guess I need the 5 secs because the lock does double turns.
Maybe use the doorlockTimeout to configure this as well?
I hope this helps.
On Tue, Mar 12, 2019 at 7:22 PM ilcato notifications@github.com wrote:
ok, @carlittoer https://github.com/carlittoer can you update also pollerupdate.js ?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-472098717, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6Zj-yaxfk7tBbsb9R-ZGnRoBjPtjIks5vV-JRgaJpZM4ap3Dj .
Not sure to understand, please describe the cases with and without Siri.
I think you need to put the same time in getFunction and in the setFunction. I can later put it in the config.json in order to better choose the value.
[3/13/2019, 10:29:30 AM] [FibaroHC2] Getting value from device: 47 parameter: Lock Current State
[3/13/2019, 10:29:40 AM] [FibaroHC2] Setting value to device: 47 parameter: Lock Target State
[3/13/2019, 10:29:40 AM] [FibaroHC2] Getting value from device: 47 parameter: Lock Current State
[3/13/2019, 10:29:40 AM] [FibaroHC2] Command: secure, value: 0, to: 47
[3/13/2019, 10:29:43 AM] [FibaroHC2] Getting value from device: 47 parameter: Lock Target State
[3/13/2019, 10:29:46 AM] [FibaroHC2] Updating value for device: 47 parameter: Lock Current State, value: true
[3/13/2019, 10:29:46 AM] [FibaroHC2] Error fetching updates: TypeError: getFunction.call is not a function
at Poller.manageValue (/homebridge/node_modules/homebridge-fibaro-hc2/src/pollerupdate.ts:116:18)
at updates.changes.map (/homebridge/node_modules/homebridge-fibaro-hc2/src/pollerupdate.ts:52:13)
at Array.map (
this is what I am getting after restart. it were too many errors but most of them were related to fibaro motion eyes.
this is before restart:
[3/13/2019, 10:13:51 AM] [FibaroHC2] Updating value for device: 22 parameter: Motion Detected, value: true
[3/13/2019, 10:13:51 AM] [FibaroHC2] Error fetching updates: TypeError: getFunction.call is not a function
at Poller.manageValue (/homebridge/node_modules/homebridge-fibaro-hc2/src/pollerupdate.ts:116:18)
at updates.changes.map (/homebridge/node_modules/homebridge-fibaro-hc2/src/pollerupdate.ts:52:13)
at Array.map (
bit bumped at it (motion eye):
[3/13/2019, 10:36:16 AM] [FibaroHC2] Updating value for device: 22 parameter: Motion Detected, value: true
[3/13/2019, 10:36:16 AM] [FibaroHC2] Error fetching updates: TypeError: getFunction.call is not a function
at Poller.manageValue (/homebridge/node_modules/homebridge-fibaro-hc2/src/pollerupdate.ts:116:18)
at updates.changes.map (/homebridge/node_modules/homebridge-fibaro-hc2/src/pollerupdate.ts:52:13)
at Array.map (
nothing of this were happening before fix #136
Hi @MindaugasRam
Please take the latest files. They fix this error in the log.
On Wed, Mar 13, 2019 at 12:38 PM MindaugasRam notifications@github.com wrote:
nothing of this were happening before fix #136 https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-472369314, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6ZvWRQFV2iy3v77IODm9bP3gbf2TEks5vWNVCgaJpZM4ap3Dj .
didn't noticed, that it was updated. Yes now works fine. Thank you
@MindaugasRam, @carlittoer. Let me recap: @MindaugasRam has no problem now. @carlittoer has a working solution with different delays (5s instead of 2s) defined in getFunctions.
Correct?
@ilcato correct
Correct except I am using the following old code in setFunctions so that when pressing on the icon in the home app (no siri) it works as well.
this.command(action, [0], service, IDs); characteristic.setValue(value, undefined, 'fromSetValue');
@MindaugasRam can you confirm what happens when you press lock / unlock in the home app now ? Is it showing that it's locked even before the lock is locked?
On Wed, Mar 13, 2019 at 1:42 PM MindaugasRam notifications@github.com wrote:
@ilcato https://github.com/ilcato correct
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-472388494, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6Zj-3C7tsJl0AC7TdvM6COJ9C6dQAks5vWOQ0gaJpZM4ap3Dj .
@carlittoer yes you are correct, it takes like 0.5 sec for locking/unlocking and shows lock/unlock even before the action is finished. And for siri to confirm lock/unlock takes about 5 sec.
So I guess we only need to make the delays in getFunctions configurable via a parameter. Right @ilcato ?
On Wed, Mar 13, 2019 at 3:11 PM MindaugasRam notifications@github.com wrote:
@carlittoer https://github.com/carlittoer yes you are correct, it takes like 0.5 sec for locking/unlocking and shows lock/unlock even before the action is finished. And for siri to confirm lock/unlock takes about 5 sec.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-472415544, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6Zl2152IHCR3LtMDqVt--SYRI_pf9ks5vWPkNgaJpZM4ap3Dj .
@carlittoer can you test with the last code for setFunctions.js and setting the value in row # 86 to the same value you put in getFunctions.js (5s). Specify also the same for the delay of LockTargetState. Thanks.
ok will try and keep you posted.
On Wed, Mar 13, 2019 at 3:16 PM ilcato notifications@github.com wrote:
@carlittoer https://github.com/carlittoer can you test with the last code for setFunctions.js and setting the value in row # 86 to the same value you put in getFunctions.js (5s). Specify also the same for the delay of LockTargetState. Thanks.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-472417244, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6Zk0mf643RuEYGjTmhQMv6yB5lbqrks5vWPpIgaJpZM4ap3Dj .
@carlittoer, any news?
Not yet sorry On Fri, Mar 15, 2019 at 2:57 PM ilcato notifications@github.com wrote:
@carlittoer https://github.com/carlittoer, any news?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-473275748, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6Zv8jVapJPzlzv2FooT_9D6Q7WC1Aks5vW5jJgaJpZM4ap3Dj .
@carlittoer, any news?
Hi !
Sorry for the late reply on this.
I've tried setting the same value in getFunctions and setFunctions.
LockCurrentState : 4s LockTargetState : 4s setFunctions timeout : 4000
It works without Siri. With Siri, it sends the sorry message.
However, I had to set the value of LockTargetState in getFunctions lower than LockCurrentState (2s and 4s respectively) for Siri lock / unlock commands to work.
LockCurrentState : 4s LockTargetState : 2s setFunctions timeout : 4000
I hope this helps.
On Mon, Mar 25, 2019 at 12:53 PM ilcato notifications@github.com wrote:
@carlittoer https://github.com/carlittoer, any news?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-476145342, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6ZihoucPiaoflU7PN8nVyJhlJQh8Tks5vaKqzgaJpZM4ap3Dj .
Can you please clarify what each timeout is supposed to be and how they work one after the other so I can test better?
On Tue, Mar 26, 2019 at 9:03 AM charles.hajj@gmail.com < charles.hajj@gmail.com> wrote:
Hi !
Sorry for the late reply on this.
I've tried setting the same value in getFunctions and setFunctions.
LockCurrentState : 4s LockTargetState : 4s setFunctions timeout : 4000
It works without Siri. With Siri, it sends the sorry message.
However, I had to set the value of LockTargetState in getFunctions lower than LockCurrentState (2s and 4s respectively) for Siri lock / unlock commands to work.
LockCurrentState : 4s LockTargetState : 2s setFunctions timeout : 4000
I hope this helps.
On Mon, Mar 25, 2019 at 12:53 PM ilcato notifications@github.com wrote:
@carlittoer https://github.com/carlittoer, any news?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-476145342, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6ZihoucPiaoflU7PN8nVyJhlJQh8Tks5vaKqzgaJpZM4ap3Dj .
In getFunctions the numbers are delays between the request received from HomeKit and the query to Home Center. In setFunctions is a delay after executing the command on Home Center to align HomeKit. @MindaugasRam can you try the @carlittoer values?
Hi, out of home, will try tomorrow.
Kind Regards Mindaugas
On 27 Mar 2019, at 22:50, ilcato notifications@github.com wrote:
In getFunctions the numbers are delays between the request received from HomeKit and the query to Home Center. In setFunctions is a delay after executing the command on Home Center to align HomeKit. @MindaugasRam can you try the @carlittoer values?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
@MindaugasRam, any feedback?
Sorry totally forgot. Will check evening and let you know
Kind Regards Mindaugas
On 5 Apr 2019, at 16:36, ilcato notifications@github.com wrote:
@MindaugasRam, any feedback?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
I can't find where do I need to change those values. Could you please clarify which line. Mine lock works no issues, but if you guys want me to try smth for you please be more specific I am not so smart ;)
Same here: Siri closes lock, but immediately responds she was not able to, even while the lock is still operating.
Changing "doorlocktimeout" parameter to 0 or 15 has no effect
Danalock V3 Z-Wave via Fibaro HC2 homebridge-fibaro-hc2@2.2.0 homebridge@0.4.44
Here is my log file:
Apr 07 14:23:04 Homebridge homebridge[870]: [2019-4-7 14:23:04] [FibaroHC2] Setting value to device: 273 parameter: Lock Target State
Apr 07 14:23:04 Homebridge homebridge[870]: [2019-4-7 14:23:04] [FibaroHC2] Command: secure, value: 0, to: 273
Apr 07 14:23:05 Homebridge homebridge[870]: [2019-4-7 14:23:05] [FibaroHC2] Getting value from device: 273 parameter: Lock Current State
Apr 07 14:23:06 Homebridge homebridge[870]: [2019-4-7 14:23:06] [FibaroHC2] Getting value from device: 273 parameter: Lock Target State
Apr 07 14:23:09 Homebridge homebridge[870]: [2019-4-7 14:23:09] [FibaroHC2] Updating value for device: 273 parameter: Lock Current State, value: true
Apr 07 14:23:09 Homebridge homebridge[870]: [2019-4-7 14:23:09] [FibaroHC2] Updating value for device: 273 parameter: Lock Target State, value: true
What is different: I do not have the error line mentioned above
[3/7/2019, 8:36:39 PM] [FibaroHC2] There was a problem setting value to Lock: 47
Let me know, if I can contribute further.
@Krillle mine danalock works perfect with a siri as well, it has bit off delay but no more error mesages. fix #136 solved my problem, and btw I have removed lock line from homebridge config
Hi, plugin works great, thanks for it. I have only issue with Siri. When I ask Siri to open or close lock, it does but responses it was unable to do it. Home kit app works perfectly. Just Siri responses are faulty. Any thoughts how to fix it. Thanks