illinois-ceesd / mirgecom

MIRGE-Com is the workhorse simulation application for the Center for Exascale-Enabled Scramjet Design at the University of Illinois.
Other
12 stars 19 forks source link

bump Python to 3.12 #1072

Closed matthiasdiener closed 1 month ago

matthiasdiener commented 1 month ago

The pytest failures do not seem to be related to:

Although generally slowdowns lead to CI cancelation in test_operators.py, testing that file separately seems to work fine (see https://github.com/illinois-ceesd/mirgecom/actions/runs/11484157110/job/31961509540).

Something about ctx_factory may be fishy - some test files use ctx_factory, some actx_factory.

Perhaps the order in which tests are run is relevant?

Or is it coverage testing?

Google sheets

matthiasdiener commented 1 month ago

Looks like coverage is our problem regarding 3.12, and it turns out 3.12 is even a bit faster than 3.11 with coverage disabled. Interestingly, there have been a few performance-related issues with coverage and 3.12, but all of these seem to hav been resolved in current package versions...

e.g., https://github.com/python/cpython/issues/119118 , https://github.com/nedbat/coveragepy/issues/1785