search

illinois / queue

A microservice queue for holding open office hours
University of Illinois/NCSA Open Source License
82 stars 36 forks source link

Preview the staff Markdown message #193

Closed sheern closed 5 years ago

sheern commented 5 years ago

markdown previews while editing messages can be shown or hidden with an added button

closes #190

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

sheern commented 5 years ago

Sure I can try out the tabs. I did make a quick attempt at it but it felt a bit clunky and unnecessary since pressing Save is about equivalent in terms of time spent. I'm guessing that time is not a big deal then, just the ability to preview?

nwalters512 commented 5 years ago

Yeah! The key thing is that saving will immediately update the message for anyone on the queue - if you just want to make sure you typed in your Markdown correctly or want to check the formatting of new content, it's best to do that locally via preview instead of saving the message. It's kind of the same logic as GitHub: I want to make sure my comment looks good before I submit it, not after.

sheern commented 5 years ago

Pretty much copy-pasted from the tabs page, could maybe be better looking but it does the job

nwalters512 commented 5 years ago

Looking better! I'm a bit of a stickler for design - want to try out something like https://getbootstrap.com/docs/4.0/components/card/#navigation to improve the appearance a bit? I'd be happy to push some changes to your branch as well.

sheern commented 5 years ago

Sorry for the delay, but here's a Github style version. Feel free to make changes to it!

nwalters512 commented 5 years ago

I just added a few more nice-to-haves: the message input now focuses itself when you start editing or switch back the the editor tab, and accessibility on the tabs themselves has been improved (thought not to the extend described above).

sheern commented 5 years ago

My pleasure, hoping to contribute more to this important project. Thanks for all your help with this PR, I've learned a lot!