search

illinois / queue

A microservice queue for holding open office hours
University of Illinois/NCSA Open Source License
82 stars 36 forks source link

On Duty Staff - Notifications for non-active queues #203

Closed HunterADyer closed 5 years ago

HunterADyer commented 5 years ago

I was logged in as an active duty staff on the CARE walk-in tutoring with notifications on, and while my tab was open to CS 225 (course in which I have never been assigned as course staff), I received notifications whenever a student added themselves to the 225 queue, but not the CARE queue.

nwalters512 commented 5 years ago

Good catch! This is definitely a problem - this stems from the fact that the activeStaff dict in the Redux state isn't cleared when navigating between pages, and we only check that the current user matches any of the active staff. We should check that for a given person in activeStaff, that the queue corresponds to a course that the user is actually staff for.