search

illinois / queue

A microservice queue for holding open office hours
University of Illinois/NCSA Open Source License
82 stars 36 forks source link

Programmatic admission control #228

Closed nwalters512 closed 5 years ago

nwalters512 commented 5 years ago

This is an implementation of the feature discussed in #226. It includes support for defining and enabling an HTTP endpoint that will determine if a question should be admitted to the queue or not. As a part of this, I build a new queue settings page where you can edit name/location/admission control/etc., as well as delete a queue.

Queue setting screenshot

As a part of this, I revamped how the API responds with errors so that they're always valid JSON. This required updating a lot of tests and such. However, it should be more sustainable in the future.

Programmatic admission control itself currently doesn't include any tests, but they'd be nice to have.

Todo:

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.