Ansible 2.0 Readiness - Githubissues

ilri / rmg-ansible-public

Ansible playbooks for ILRI research-computing infrastructure

GNU General Public License v3.0

8 stars 2 forks source link

Ansible 2.0 Readiness #22

Closed alanorth closed 8 years ago

alanorth commented 8 years ago

In #21 @oguya pointed out that there is an Ansible 2.0 porting guide that we should really look at, as some of our playbooks are using old conventions that work now, but will be unsupported by version 2.2.

For example:

[x] We cleaned up some use of sudo_user but there are still more buried in the playbooks (dspace tomcat stuff)
[x] Don't forget the misc-plays too!

oguya commented 8 years ago

@alanorth I presume you're also using ansible v2.0 from pip or something of the sort, & not relying on just the porting guide, right? :wink:

alanorth commented 8 years ago

Does Luke Skywalker ask Yoda if he knows how to use his lightsaber?

oguya commented 8 years ago

haha! What an analogy. I guess I'm Yoda, you can be Luke :stuck_out_tongue_winking_eye:

oguya commented 8 years ago

In misc_plays, there were a bunch of sudo directives that I changed to become. See 29dec59

oguya commented 8 years ago

Apart from sudo/sudo_user & bare variables in with_ loops, I don't see any other changes to make.

oguya commented 8 years ago

I guess we've been following Ansible best practices to the letter :+1: If a warning related to 2.0 pops up, we'll just fix it on master, otherwise, this is good to go.

alanorth commented 8 years ago

I think you're right, we did some cleanups for good practices at one point last year as well. LGTM.