ilyakurdyukov / jpeg-quantsmooth

JPEG artifacts removal based on quantization coefficients.
GNU Lesser General Public License v2.1
245 stars 21 forks source link

Prog name? #2

Closed zvezdochiot closed 4 years ago

zvezdochiot commented 4 years ago

https://github.com/ilyakurdyukov/jpeg-quantsmooth/blob/fb02bb23999e5986ea6340d262556e59feec0d4e/Makefile#L7-L15

Maybe?:

PNAME = jpegqs
...
all: $(PNAME)

clean:
    rm -rf $(PNAME)

$(PNAME): quantsmooth.h idct.h

$(PNAME): quantsmooth.c
    $(CC) $(CFLAGS) -s -o $@ $< $(LIBS)

And: https://github.com/ilyakurdyukov/jpeg-quantsmooth/blob/fb02bb23999e5986ea6340d262556e59feec0d4e/quantsmooth.c#L185 To:

    const char *progname = argv[0], *fn;
ilyakurdyukov commented 4 years ago

I'll change it over time. I'm more thinking about: 1) improving quality, 2) improving performance, 3) actual bugs?.

zvezdochiot commented 4 years ago

@ilyakurdyukov say:

I'll change it over time.

Ok.

ilyakurdyukov commented 4 years ago

Added similar changes, but with define named "APPNAME".

zvezdochiot commented 4 years ago

quantsmooth is too long and does not indicate the basic nature of the program. Less bad is jpegqs.

Fixed: https://github.com/ilyakurdyukov/jpeg-quantsmooth/commit/67bac148178cde08b762cfbcfd4798c90176c93b